-
Notifications
You must be signed in to change notification settings - Fork 63
chore: Migrate coalesce_op operator to SQLGlot #2211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Migrated the coalesce_op operator from Ibis to SQLGlot.
|
The ibis sql: |
| ) | ||
|
|
||
|
|
||
| @register_binary_op(ops.coalesce_op) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please enable the existing engine test test_engines_coalesce_op by adding "bq-sqlglot" to the "engine" parameters.
| @pytest.mark.parametrize("engine", ["polars", "bq"], indirect=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks.
Migrated the coalesce_op operator from Ibis to SQLGlot.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes b/447388852 🦕