feat: Support args in series apply method #2013
Open
+101
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
shuoweil
approved these changes
Aug 21, 2025
shobsi
reviewed
Aug 23, 2025
| func, | ||
| by_row: typing.Union[typing.Literal["compat"], bool] = "compat", | ||
| *, | ||
| args: typing.Tuple = (), |
There was a problem hiding this comment.
In pandas args can be a positional argument while by_row is a keyword only argument https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.Series.apply.html#pandas-series-apply. I would argue that we can adhere to that right now as I don't anticipate many people passing by_row positional argument, but if not, we should add an item in BigFrames 3.0 to make the breaking change.
| bf_result_col = scalars_df["int64_too"].apply( | ||
| foo_list, args=(12.34, b"hello world", False) | ||
| ) | ||
| bf_result = ( |
There was a problem hiding this comment.
wondering why we need to convert to put it in a DataFrame before asserting. Can't we compare bf_result_col and pd_result_col directly?
| ) | ||
|
|
||
| # Ignore any dtype difference. | ||
| pandas.testing.assert_frame_equal(bf_result, pd_result, check_dtype=False) |
There was a problem hiding this comment.
Same as the other comment, why not assert_series_equal on the result of the apply?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes b/440342212.