feat: Allow local arithmetic execution in hybrid engine #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
TrevorBergeron
force-pushed
the
hybrid_math
branch
from
dd71fac to
a082510
Compare
product-auto-label
bot
added
size: l
TrevorBergeron
force-pushed
the
hybrid_math
branch
from
a082510 to
74c3051
Compare
TrevorBergeron
requested review from
chelsea-lin
and removed request for
jialuoo
chelsea-lin
approved these changes
Jul 16, 2025
| ): | ||
| rarg = ops.AsTypeOp(to_type=dtypes.DATETIME_DTYPE).as_expr(rarg) | ||
|
|
||
| return expr.op.as_expr(larg, rarg) |
There was a problem hiding this comment.
Will the function throw an error if an argument has an invalid type? Or you just let Polar throws errors?
| @@ -140,7 +140,8 @@ class AddOp(base_ops.BinaryOp): | |||
| def output_type(self, *input_types): | |||
| left_type = input_types[0] | |||
| right_type = input_types[1] | |||
| if all(map(dtypes.is_string_like, input_types)) and len(set(input_types)) == 1: | |||
| # TODO: Binary/bytes addition requires impl | |||
There was a problem hiding this comment.
Could you please create a bug for this TODO? It can be part of pandas top-100 hostlist?
There was a problem hiding this comment.
created issue 432495312
| @@ -37,26 +37,259 @@ def lower(self, expr: expression.OpExpression) -> expression.Expression: | |||
| return expr.op.as_expr(larg, rarg) | |||
|
|
|||
|
|
|||
| class LowerAddRule(op_lowering.OpLoweringRule): | |||
There was a problem hiding this comment.
Can you help me understand why it's calling "lower" here?
There was a problem hiding this comment.
I saw the term used in some other compiler-related things: https://stackoverflow.com/questions/20252876/wanted-good-definition-of-the-term-lowering-in-the-context-of-compilers/21295297#21295297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕