chore: move polar and scikit-learn to test extras pacakges #1740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
chelsea-lin
force-pushed
the
main_chelselain_extrassetup
branch
from
f3dfc9f to
c10d24c
Compare
| ], | ||
| # used for local engine, which is only needed for unit tests at present. | ||
| "polars": ["polars >= 1.7.0"], |
There was a problem hiding this comment.
Might actually be using this stuff for user-facing features soon, so would rather not move to test-only dependencies
There was a problem hiding this comment.
The extract category in setup.py is being generalized for better organization, moving away from test-specific configurations. This is primarily a cleanup effort. If you want to add Polars later if needed, please sent another PR with "deps: " title for better release notes.
chelsea-lin
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.