Skip to content

Commit f3dfc9f

Browse files
committed
chore: move polar and scikit-learn to test extras pacakges
1 parent 55c07e9 commit f3dfc9f

File tree

2 files changed

+7
-15
lines changed

2 files changed

+7
-15
lines changed

noxfile.py

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,7 @@
7777
UNIT_TEST_LOCAL_DEPENDENCIES: List[str] = []
7878
UNIT_TEST_DEPENDENCIES: List[str] = []
7979
UNIT_TEST_EXTRAS: List[str] = ["tests"]
80-
UNIT_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = {
81-
"3.12": ["polars", "scikit-learn"],
82-
}
80+
UNIT_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = {}
8381

8482
# 3.10 is needed for Windows tests as it is the only version installed in the
8583
# bigframes-windows container image. For more information, search
@@ -103,13 +101,8 @@
103101
]
104102
SYSTEM_TEST_LOCAL_DEPENDENCIES: List[str] = []
105103
SYSTEM_TEST_DEPENDENCIES: List[str] = []
106-
SYSTEM_TEST_EXTRAS: List[str] = []
107-
SYSTEM_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = {
108-
"3.9": ["tests"],
109-
"3.10": ["tests"],
110-
"3.12": ["tests", "scikit-learn"],
111-
"3.13": ["tests"],
112-
}
104+
SYSTEM_TEST_EXTRAS: List[str] = ["tests"]
105+
SYSTEM_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = {}
113106

114107
LOGGING_NAME_ENV_VAR = "BIGFRAMES_PERFORMANCE_LOG_NAME"
115108

@@ -312,7 +305,7 @@ def install_systemtest_dependencies(session, install_test_extra, *constraints):
312305

313306
if install_test_extra and SYSTEM_TEST_EXTRAS_BY_PYTHON:
314307
extras = SYSTEM_TEST_EXTRAS_BY_PYTHON.get(session.python, [])
315-
elif install_test_extra and SYSTEM_TEST_EXTRAS:
308+
if install_test_extra and SYSTEM_TEST_EXTRAS:
316309
extras = SYSTEM_TEST_EXTRAS
317310
else:
318311
extras = []

setup.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,12 @@
7272
# Optional test dependencies packages. If they're missed, may skip some tests.
7373
"tests": [
7474
"freezegun",
75-
"pytest-snapshot",
7675
"google-cloud-bigtable >=2.24.0",
7776
"google-cloud-pubsub >=2.21.4",
77+
"polars >= 1.7.0",
78+
"pytest-snapshot",
79+
"scikit-learn>=1.2.2",
7880
],
79-
# used for local engine, which is only needed for unit tests at present.
80-
"polars": ["polars >= 1.7.0"],
81-
"scikit-learn": ["scikit-learn>=1.2.2"],
8281
# Packages required for basic development flow.
8382
"dev": [
8483
"pytest",

0 commit comments

Comments
 (0)