feat: add custom progress reporting to anywidget display mode #1733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
tswast
force-pushed
the
b409104302-callback
branch
from
21ca375 to
f8a3f64
Compare
product-auto-label
bot
added
size: l
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
tswast
changed the title
tswast
commented
Sep 6, 2025
| @@ -679,6 +680,7 @@ def to_pandas_batches( | |||
| page_size: Optional[int] = None, | |||
| max_results: Optional[int] = None, | |||
| allow_large_results: Optional[bool] = None, | |||
| callback: Callable = lambda _: None, | |||
There was a problem hiding this comment.
Per discussion offline, we may want to provide a global progress publisher object rather than add callbacks to each method that needs them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also,
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕