Skip to content

chore: add pyformat_args to _read_gbq_colab #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 9, 2025
Merged

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented May 7, 2025

Follow-up to #1688

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 7, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels May 8, 2025
@tswast tswast marked this pull request as ready for review May 8, 2025 17:34
@tswast tswast requested review from a team as code owners May 8, 2025 17:34
@tswast tswast requested a review from TrevorBergeron May 8, 2025 17:34
@tswast
Copy link
Collaborator Author

tswast commented May 9, 2025

Chatted offline. Will update to avoid injecting unescaped strings. I'm considering adding google-cloud-bigquery Table* objects as a simpler alternative that can be used to represent a table before following up with DataFrame support.

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels May 9, 2025
@tswast tswast merged commit c260fc8 into main May 9, 2025
24 checks passed
@tswast tswast deleted the b409306077-pyformat branch May 9, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants