Skip to content

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 3, 2025
@TrevorBergeron TrevorBergeron force-pushed the almost_anything_inline branch from fc4e2ea to fc4b243 Compare April 4, 2025 00:27
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Apr 4, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review April 4, 2025 00:28
@TrevorBergeron TrevorBergeron requested review from a team as code owners April 4, 2025 00:28
@TrevorBergeron TrevorBergeron requested a review from jialuoo April 4, 2025 00:28
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks!

@@ -478,16 +476,3 @@ def test_read_pandas_inline_w_interval_type_raises_error():
df = pd.DataFrame(pd.arrays.IntervalArray.from_breaks([0, 10, 20, 30, 40, 50]))
with pytest.raises(ValueError, match="Could not convert with a BigQuery type: "):
session.read_pandas(df, write_engine="bigquery_inline")


def test_read_pandas_inline_w_noninlineable_type_raises_error():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this test for Geo data?

@arwas11 arwas11 removed their assignment Apr 4, 2025
@TrevorBergeron TrevorBergeron merged commit 2ce891f into main Apr 4, 2025
23 of 24 checks passed
@TrevorBergeron TrevorBergeron deleted the almost_anything_inline branch April 4, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants