Skip to content

chore: add feedback link to all functions exceptions #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 13, 2025

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Mar 7, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@shobsi shobsi requested review from a team as code owners March 7, 2025 08:05
@shobsi shobsi requested a review from ZehaoXU March 7, 2025 08:05
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 7, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Mar 7, 2025
@shobsi shobsi requested a review from jialuoo March 7, 2025 08:26
@shobsi shobsi merged commit 3a0dbe1 into main Mar 13, 2025
24 checks passed
@shobsi shobsi deleted the shobs-exception-feedback-link branch March 13, 2025 17:46
shuoweil pushed a commit that referenced this pull request Mar 19, 2025
* chore: add feedback link to all functions exceptions

* expect feedback link in the test exception

* expect feedback link in test exceptions

* use f-string instead of format, update one more test to expect feedback link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants