Skip to content

feat: add bigframes.bigquery.st_area and suggest it from GeoSeries.area #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 24 commits into from
Feb 4, 2025
Merged

feat: add bigframes.bigquery.st_area and suggest it from GeoSeries.area #1318

tswast merged 24 commits into from
Feb 4, 2025

Conversation

@arwas11
Copy link
Contributor

@arwas11 arwas11 commented Jan 23, 2025 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
    • area: screen/5SjGQsfX3K4mHpK
    • st_area: screen/7X3xcQcsp968m4a, screen/3LrwWASNt26Whoa, screen/6VUmo2GL6BDjFKA

Fixes #393394363 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 23, 2025
tswast
tswast reviewed Jan 27, 2025
View reviewed changes
tswast
tswast reviewed Feb 4, 2025
View reviewed changes
tswast
tswast reviewed Feb 4, 2025
View reviewed changes
@review-notebook-app
Copy link

review-notebook-app bot commented Feb 4, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Feb 4, 2025
@arwas11 arwas11 marked this pull request as ready for review February 4, 2025 17:36
@arwas11 arwas11 requested review from a team as code owners February 4, 2025 17:36
@arwas11 arwas11 requested a review from tswast February 4, 2025 17:36
@tswast tswast changed the title feat: Add GeoSeries.area feat: add bigframes.bigquery.st_area and suggest it from GeoSeries.area Feb 4, 2025
arwas11
arwas11 commented Feb 4, 2025
View reviewed changes
arwas11
arwas11 commented Feb 4, 2025
View reviewed changes
tswast
tswast reviewed Feb 4, 2025
View reviewed changes
tswast
tswast reviewed Feb 4, 2025
View reviewed changes
@tswast tswast enabled auto-merge (squash) February 4, 2025 20:31
@tswast tswast disabled auto-merge February 4, 2025 21:18
@tswast
Copy link
Collaborator

tswast commented Feb 4, 2025

Failed doctests are

FAILED bigframes/session/__init__.py::bigframes.session.Session.read_gbq_function
FAILED bigframes/pandas/io/api.py::bigframes.pandas.io.api.read_gbq_function

which appears unrelated.

@tswast tswast merged commit 8b5ffa8 into main Feb 4, 2025
21 of 23 checks passed
@tswast tswast deleted the b308738592-geopandas-area branch February 4, 2025 21:19
@release-please release-please bot mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

Assignees

@jiaxunwu jiaxunwu

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arwas11 @tswast @jiaxunwu