fix: suppress no project id warning

[morgandu]

Fixes https://b.corp.google.com/issues/176166878

[sasha-gitg]

This seems like it would cause unintended side effects as other SDKs may reference this environment variable. I think we need to:

1. Determine the source of the warning and the call site in the SDK that leads to warning being logged.
2. See if we can avoid calling that method when we have project or pass project to the method.

It looks like this is the source of the warning:
https://github.com/googleapis/google-auth-library-python/blob/master/google/auth/_default.py#L251

My first guess is that it's called here:

python-aiplatform/google/cloud/aiplatform/initializer.py

Line 95 in be78cde

_, project_id = google.auth.default()

But I suspect that assumption is incorrect because, if the project set, it shouldn't invoke that method. So the issue may lie elsewhere.

[busunkim96]

Yep, GOOGLE_CLOUD_PROJECT is one of the standardized environment variables respected across libraries so overriding this may have unintended side effects. docs

FWIW the existing behavior makes sense to me - the warning only seems to be raised if the user has both (1) not passed a project to __init__ and (2) not set a project in the environment.

python-aiplatform/google/cloud/aiplatform/initializer.py

Lines 44 to 67 in 4459fff

	def init(
	self,
	*,
	project: Optional[str] = None,
	location: Optional[str] = None,
	experiment: Optional[str] = None,
	staging_bucket: Optional[str] = None,
	credentials: Optional[auth_credentials.Credentials] = None,
	):
	"""Updates common initalization parameters with provided options.
	Args:
	project (str): The default project to use when making API calls.
	location (str): The default location to use when making API calls. If not
	set defaults to us-central-1
	experiment (str): The experiment to assign
	staging_bucket (str): The default staging bucket to use to stage artifacts
	when making API calls. In the form gs://...
	credentials (google.auth.crendentials.Crendentials): The default custom
	credentials to use when making API calls. If not provided crendentials
	will be ascertained from the environment.
	"""
	if project:
	self._project = project

python-aiplatform/google/cloud/aiplatform/initializer.py

Lines 79 to 100 in 4459fff

	@property
	def project(self) -> str:
	"""Default project."""
	if self._project:
	return self._project
	project_not_found_exception_str = (
	"Unable to find your project. Please provide a project ID by:"
	"\n- Passing a constructor argument"
	"\n- Using aiplatform.init()"
	"\n- Setting a GCP environment variable"
	)
	try:
	_, project_id = google.auth.default()
	except GoogleAuthError:
	raise GoogleAuthError(project_not_found_exception_str)
	if not project_id:
	raise ValueError(project_not_found_exception_str)
	return project_id

[morgandu]

@sasha-gitg , @busunkim96

I thought at the beginning the warning was from

python-aiplatform/google/cloud/aiplatform/initializer.py

Line 95 in be78cde

_, project_id = google.auth.default()

But using Dataset as example, the warning comes from

python-aiplatform/google/cloud/aiplatform_v1beta1/services/dataset_service/transports/grpc.py

Line 130 in be78cde

credentials, _ = auth.default(

when credential is None

I think this warning has nothing to do with MBSDK, it is more for a warning from google.auth, to indicate the gcloud nor environment variable is not set. And the google.auth.default() is triggered when there is a transport grpc call.

[morgandu]

@sasha-gitg , @busunkim96
modified approached: when no credentials is provided during MBSDK initialization, set the credentials initializer.global_config._credentials to google.auth.default's credentials, thus during any service client instantiation, google.auth.default will not be called again.

[sasha-gitg]

LGTM! Thanks for putting this together. One minor change for consistency.

[sasha-gitg]

Please move this logic into the credentials property to be consistent with the default project retrieval. Default project is pulled at time of accessing the property while, in this case, default credential is pulled when initializing the config.