fix: fix conda compatibility issue #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthea
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
ohmayr
reviewed
Jul 12, 2024
| except AttributeError: | ||
| # The `MessageMapContainer` attribute is not available in Protobuf 5.x+ | ||
| pass | ||
| for message in [_message_upb, _message_pyext]: |
There was a problem hiding this comment.
Why do we need a for loop here? Are _message_upb and _message_pyext mutually exclusive?
There was a problem hiding this comment.
As per the comment at line 23, we want to include types from both _message_upb and _message_pyext
ohmayr
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #471 but with review comments addressed.
Fixes #470
Fixes googleapis/python-aiplatform#3129
Closes #471