Add typing for File#download() #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
Author
|
Running |
Contributor
Author
|
Is this under consideration to be merged? |
Contributor
JustinBeckwith
left a comment
JustinBeckwith
left a comment
There was a problem hiding this comment.
Thanks for the PR! If we could keep the jsdoc comments in tact (we use these for docs), LGTM :)
| (this.parent as ServiceObject).delete.call(this, options, callback); | ||
| } | ||
|
|
||
| /** |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
I believe I have moved all JSDoc now. Do you want me to duplicate their types, considering they are already defined by Typescript? |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Typescript types for File#download().