Skip to content

Enable prefer-const in the eslint config #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-fenster merged 1 commit into from
Sep 20, 2018
Merged

Enable prefer-const in the eslint config #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ rules:
eqeqeq: error
no-warning-comments: warn
no-var: error
prefer-const: error
2 changes: 1 addition & 1 deletion samples/iam.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ function removeBucketIamMember(bucketName, roleName, members) {

// Finds and updates the appropriate role-member group
const index = policy.bindings.findIndex(role => role.role === roleName);
let role = policy.bindings[index];
const role = policy.bindings[index];
if (role) {
role.members = role.members.filter(
member => members.indexOf(member) === -1
Expand Down
2 changes: 1 addition & 1 deletion samples/system-test/encryption.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ test.serial(`should rotate keys`, async t => {
const output = generateKeyResults.stdout + generateKeyResults.stderr;
t.regex(output, new RegExp(`Base 64 encoded encryption key:`));
const test = /^Base 64 encoded encryption key: (.+)$/;
let newKey = output.match(test)[1];
const newKey = output.match(test)[1];

const results = await tools.runAsyncWithIO(
`${cmd} rotate ${bucketName} ${fileName} ${key} ${newKey}`,
Expand Down