Invalid credentials results in empty list rather than error

[fhinkel]

In 1.7, you would get an error if the credentials are invalid. Now the getBuckets() promise is resolved and it looks like you have no buckets. Is that behavior intended? I can't find it anywhere in the docs.

const Storage = require('@google-cloud/storage');

  // Invalid credentials
  const storage = new Storage({
    keyFilename: '/Users/foo.json'
  });

  // Makes an authenticated API request.
  storage
    .getBuckets()
    .then((results) => {
      const buckets = results[0];

      console.log('Buckets:');
      buckets.forEach((bucket) => {
        console.log(bucket.name);
      });
    })
    .catch((err) => {
      console.error('ERROR:', err);
      console.log('such error');
    });

[stephenplusplus]

In 2.0.3, if these aren't set:

• keyFilename
• env var GOOGLE_APPLICATION_CREDENTIALS

I get an error:

Error: Could not load the default credentials. Browse to https://developers.google.com/accounts/docs/application-default-credentials for more information.

What is invalid about the /Users/foo.json file?

[fhinkel]

The file doesn't exist. I'm passing in the keyfilename, it shouldn't look for default credentials.

[JustinBeckwith]

I don't see this scratches head:

gal-415 $ node server.js 
ERROR: { [Error: ENOENT: no such file or directory, open '/Users/foo.json']
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/Users/foo.json' }
such error

With this code:

const {Storage} = require('@google-cloud/storage');

// Invalid credentials
const storage = new Storage({
  keyFilename: '/Users/foo.json'
});

// Makes an authenticated API request.
storage
  .getBuckets()
  .then((results) => {
    const buckets = results[0];

    console.log('Buckets:');
    buckets.forEach((bucket) => {
      console.log(bucket.name);
    });
  })
  .catch((err) => {
    console.error('ERROR:', err);
    console.log('such error');
  });

Using 2.0.3:

"dependencies": {
    "@google-cloud/storage": "^2.0.3"
  }

Using nodejs 10.9. One thing to note - you have to destructure the Storage require.

[fhinkel]

I think it depends on the application default credentials that we fall back to for auth. An auth sample test is failing for me after the update. The test checks that the promise is not resolving with invalid credentials - where as I get an empty result rather than a rejection.

[fhinkel]

Edit: I'm assuming it's falling back to a different account locally, which doesn't have a bucket with the specified name - so it's not 403 or no result. Never mind.

[barocsi]

Can you only provide a keyfilename? Or a credentials objects according to this: https://github.com/googleapis/google-cloud-node/blob/master/docs/authentication.md,