Skip to content

fix: make FlushPolicy${Min,Max}FlushSizeFlushPolicy constructors private #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: make FlushPolicy${Min,Max}FlushSizeFlushPolicy constructors private #3217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions google-cloud-storage/clirr-ignored-differences.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,4 +161,21 @@
<method>com.google.cloud.storage.BucketInfo$Builder setGoogleManagedEncryptionEnforcementConfig(com.google.cloud.storage.BucketInfo$GoogleManagedEncryptionEnforcementConfig)</method>
</difference>

<!-- make beta api constructors private, they still retain their factory methods. -->
<difference>
<differenceType>7004</differenceType>
<className>com/google/cloud/storage/FlushPolicy$MinFlushSizeFlushPolicy</className>
<method>FlushPolicy$MinFlushSizeFlushPolicy(int)</method>
</difference>
<difference>
<differenceType>7009</differenceType>
<className>com/google/cloud/storage/FlushPolicy$MinFlushSizeFlushPolicy</className>
<method>FlushPolicy$MinFlushSizeFlushPolicy(int)</method>
</difference>
<difference>
<differenceType>7009</differenceType>
<className>com/google/cloud/storage/FlushPolicy$MaxFlushSizeFlushPolicy</className>
<method>FlushPolicy$MaxFlushSizeFlushPolicy(int)</method>
</difference>

</differences>
4 changes: 2 additions & 2 deletions google-cloud-storage/src/main/java/com/google/cloud/storage/FlushPolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public static final class MaxFlushSizeFlushPolicy extends FlushPolicy {

private final int maxFlushSize;

public MaxFlushSizeFlushPolicy(int maxFlushSize) {
private MaxFlushSizeFlushPolicy(int maxFlushSize) {
this.maxFlushSize = maxFlushSize;
}

Expand Down Expand Up @@ -195,7 +195,7 @@ public static final class MinFlushSizeFlushPolicy extends FlushPolicy {

private final int minFlushSize;

public MinFlushSizeFlushPolicy(int minFlushSize) {
private MinFlushSizeFlushPolicy(int minFlushSize) {
this.minFlushSize = minFlushSize;
}

Expand Down
Loading