Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<junixsocket.version>2.10.1</junixsocket.version>
<opentelemetry.version>1.56.0</opentelemetry.version>
<opentelemetry.version>1.57.0</opentelemetry.version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This version property override in the benchmarks module can cause dependency conflicts.

  1. Internal inconsistency: The opentelemetry-api and opentelemetry-context dependencies (lines 43-49) in this file do not use this version property. They will resolve to the version in the parent BOM, while the SDK artifacts use this new version. This can lead to runtime errors if the API and SDK versions are incompatible.
  2. External inconsistency: The benchmarks module depends on google-cloud-spanner, which uses the OpenTelemetry version from the parent BOM. Overriding the version here can lead to having two different versions of OpenTelemetry on the classpath during benchmark execution.

Recommendation:
To ensure consistent dependency versions across the project, it would be best to remove this local opentelemetry.version property and let all OpenTelemetry dependencies be managed by the parent dependencyManagement. If overriding is necessary for benchmarks, please ensure all io.opentelemetry artifacts in this file use this property for consistency.

<google.cloud.monitoring.version>3.81.0</google.cloud.monitoring.version>
</properties>

Expand Down