-
Notifications
You must be signed in to change notification settings - Fork 135
deps: update opentelemetry.version to v1.57.0 #4255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate-bot
wants to merge
1
commit into
googleapis:main
Choose a base branch
from
renovate-bot:renovate/opentelemetry.version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version property override in the
benchmarksmodule can cause dependency conflicts.opentelemetry-apiandopentelemetry-contextdependencies (lines 43-49) in this file do not use this version property. They will resolve to the version in the parent BOM, while the SDK artifacts use this new version. This can lead to runtime errors if the API and SDK versions are incompatible.benchmarksmodule depends ongoogle-cloud-spanner, which uses the OpenTelemetry version from the parent BOM. Overriding the version here can lead to having two different versions of OpenTelemetry on the classpath during benchmark execution.Recommendation:
To ensure consistent dependency versions across the project, it would be best to remove this local
opentelemetry.versionproperty and let all OpenTelemetry dependencies be managed by the parentdependencyManagement. If overriding is necessary for benchmarks, please ensure allio.opentelemetryartifacts in this file use this property for consistency.