Skip to content

samples: create BigQuery subscription #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anguillanneuf merged 29 commits into from
Jun 22, 2022
Merged

samples: create BigQuery subscription #1168

anguillanneuf merged 29 commits into from
Jun 22, 2022

Conversation

@kamalaboulhosn
Copy link
Contributor

@kamalaboulhosn kamalaboulhosn commented Jun 17, 2022

No description provided.

@kamalaboulhosn
feat: Add flow control support to publisher
2b50adb
@kamalaboulhosn
make suggested fixes
6bb47bc
@kamalaboulhosn
Merge remote-tracking branch 'upstream/master'
0ffda7c
@kamalaboulhosn
chore: Remove note that ordering keys requires enablements.
9c113c3
@kamalaboulhosn
Merge remote-tracking branch 'upstream/master'
2a295c1
@kamalaboulhosn
feat: Add support for server-side flow control
6947740
@kamalaboulhosn
Revert "chore: Remove note that ordering keys requires enablements."
fb08aa3 
This reverts commit 9c113c3.
@kamalaboulhosn
Merge remote-tracking branch 'upstream/master'
304059f
@kamalaboulhosn
fix: Fix import order
c9c2028
@kamalaboulhosn
Merge remote-tracking branch 'upstream/master' into master
7b50aa1
@kamalaboulhosn
fix: Make error message more clear about where ordering must be enabl…
78ab82d 
…ed when publishing.
@kamalaboulhosn
Merge remote-tracking branch 'upstream/master'
dc62fb7
@kamalaboulhosn
fix: Ensure that messages that are in pending batches for an ordering…
8b73467 
… key are canceled when a previous publish for the ordering keys fails.
@kamalaboulhosn
Merge remote-tracking branch 'upstream/master'
75dc73e
@kamalaboulhosn
fix: Only check keyHasError if ordering keys is non-empty
8be37d7
@kamalaboulhosn
Merge remote-tracking branch 'upstream/master'
f2cded5
@kamalaboulhosn
Merge remote-tracking branch 'upstream/master'
e1f347b
@kamalaboulhosn
fix: Set publish timeouts to be consistent with desired values
83342f5
@kamalaboulhosn
Merge remote-tracking branch 'upstream/main'
27d4e75
@kamalaboulhosn
Merge remote-tracking branch 'upstream/main'
de32d95
@kamalaboulhosn
samples: create BigQuery subscription
b40094d
@kamalaboulhosn
samples: create BigQuery subscription
3ee105d
@kamalaboulhosn
samples: create BigQuery subscription
37e842f
@kamalaboulhosn kamalaboulhosn requested review from a team as code owners June 17, 2022 17:29
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 17, 2022
@snippet-bot
Copy link

snippet-bot bot commented Jun 17, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels Jun 17, 2022
@kamalaboulhosn kamalaboulhosn requested a review from mmicatka June 17, 2022 17:43
mmicatka
mmicatka approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@mmicatka mmicatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anguillanneuf
anguillanneuf requested changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. A few nits. Samples tests now pass.

anguillanneuf
anguillanneuf reviewed Jun 21, 2022
View reviewed changes
@anguillanneuf anguillanneuf added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 21, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 21, 2022
anguillanneuf
anguillanneuf approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@kamalaboulhosn kamalaboulhosn added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 22, 2022
@anguillanneuf
Copy link
Contributor

anguillanneuf commented Jun 22, 2022

Samples tests will pass when roles propagate. See internal cl/456386109.

@anguillanneuf anguillanneuf added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 22, 2022
@anguillanneuf anguillanneuf added owlbot:ignore instruct owl-bot to ignore a PR and removed owlbot:ignore instruct owl-bot to ignore a PR labels Jun 22, 2022
@anguillanneuf
Copy link
Contributor

anguillanneuf commented Jun 22, 2022

Added owlbot:ignore by mistake. Owlbot correctly updated README.md.

@anguillanneuf anguillanneuf merged commit d965075 into googleapis:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

+1 more reviewer

@mmicatka mmicatka mmicatka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anguillanneuf anguillanneuf

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kamalaboulhosn @anguillanneuf @mmicatka @yoshi-kokoro