Skip to content

Conversation

chingor13
Copy link
Collaborator

This is needed to get the install snippets for cloudsite out of the README and into managed pom.xml files (samples/install-with-bom/pom.xml and samples/install-without-bom/pom.xml). The snippets are copied unaltered from https://github.com/GoogleCloudPlatform/java-docs-samples/tree/master/logging/cloud-client

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 20, 2020
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #98 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #98      +/-   ##
============================================
- Coverage     76.99%   76.85%   -0.15%     
+ Complexity      582      530      -52     
============================================
  Files            42       42              
  Lines          3426     3318     -108     
  Branches        237      212      -25     
============================================
- Hits           2638     2550      -88     
+ Misses          641      625      -16     
+ Partials        147      143       -4     
Impacted Files Coverage Δ Complexity Δ
...loud/logging/v2/stub/GrpcLoggingServiceV2Stub.java 89.65% <0.00%> (-0.75%) 11.00% <0.00%> (-1.00%)
...loud/logging/v2/stub/GrpcMetricsServiceV2Stub.java 91.66% <0.00%> (-0.59%) 11.00% <0.00%> (-1.00%)
.../logging/v2/stub/MetricsServiceV2StubSettings.java 81.81% <0.00%> (-0.41%) 15.00% <0.00%> (-1.00%)
...ava/com/google/cloud/logging/v2/LoggingClient.java 69.23% <0.00%> (-0.37%) 17.00% <0.00%> (-4.00%)
...cloud/logging/v2/stub/GrpcConfigServiceV2Stub.java 95.63% <0.00%> (-0.37%) 18.00% <0.00%> (-1.00%)
.../logging/v2/stub/LoggingServiceV2StubSettings.java 81.19% <0.00%> (-0.34%) 15.00% <0.00%> (-1.00%)
...d/logging/v2/stub/ConfigServiceV2StubSettings.java 83.85% <0.00%> (-0.29%) 22.00% <0.00%> (-1.00%)
...ain/java/com/google/cloud/logging/LoggingImpl.java 87.64% <0.00%> (-0.26%) 61.00% <0.00%> (-12.00%)
...c/main/java/com/google/cloud/logging/SinkInfo.java 81.92% <0.00%> (-0.11%) 17.00% <0.00%> (-2.00%)
...ain/java/com/google/cloud/logging/HttpRequest.java 91.44% <0.00%> (-0.05%) 44.00% <0.00%> (-12.00%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55f6936...737dd4f. Read the comment docs.

@chingor13 chingor13 merged commit 0b55164 into master Feb 20, 2020
@chingor13 chingor13 deleted the import-samples branch February 20, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants