Skip to content

fix: Make LoggingHandler.logEntryFor extensible #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2022
Merged

fix: Make LoggingHandler.logEntryFor extensible #1021

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74fb115
feat: Make LoggingHandler.logEntryFor extensible
Jul 30, 2022
278edd0
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ public void publish(LogRecord record) {
}
LogEntry logEntry;
try {
logEntry = logEntryFor(record);
logEntry = logEntryFor(record).build();
} catch (Exception ex) {
getErrorManager().error(null, ex, ErrorManager.FORMAT_FAILURE);
return;
Expand Down Expand Up @@ -343,7 +343,7 @@ private MonitoredResource getMonitoredResource() {
return null;
}

private LogEntry logEntryFor(LogRecord record) throws Exception {
protected LogEntry.Builder logEntryFor(LogRecord record) throws Exception {
String payload = getFormatter().format(record);
Level level = record.getLevel();
LogEntry.Builder builder =
Expand All @@ -360,7 +360,7 @@ private LogEntry logEntryFor(LogRecord record) throws Exception {
for (LoggingEnhancer enhancer : enhancers) {
enhancer.enhanceLogEntry(builder);
}
return builder.build();
return builder;
}

@Override
Expand Down