Allow configuration for maxOutstandingElementCount and limitExceededBehavior

[edudar]

The current behavior is hardcoded as Block in GrpcLoggingRpc. This creates a problem, though. We run in a containerized environment with little overhead room for extra memory allocations. One of our services went down because Stackdriver was unavailable due to the 'quota exceeded' error, and log messages were piling up waiting to be sent. I'd sacrifice a few or a hundred log messages instead of a service. We use LoggingAppender with Logback. There seems to be no way to configure anything in the FlowControlSettings. I want to set a lower number for outstanding elements (like 1,000 instead of 100,000) and Ignore/ThrowException for limit behavior so that messages are discarded if they can't be delivered.

[blakeli0]

@edudar FlowControlSettings does expose setMaxOutstandingElementCount, see here, is that good enough for your use case?

[edudar]

@blakeli0 none of these are accessible with v1 logging, from what I can tell. And that's what com.google.cloud.logging.logback uses. Even the main README in this repo and https://cloud.google.com/logging/docs/reference/libraries use v1 API.

I see that there seems to be a way to do that in v2 via LoggingClient(LoggingSettings->writeLogEntriesSettings->batchingSettings->flowControlSettings), probably, but that requires using logging client directly, which is not a feasible alternative.

[losalex]

@edudar , this is correct - I exposed an ability to set BatchingSettings through LoggingOptions, you can see linked code change. Please let me know if that resolves your issue or anything is missing.

[edudar]

Thank you!
It'd be perfect if these were available through standard logging adapters like slf4j/logback. Something like

<appender name="CLOUD" class="com.google.cloud.logging.logback.LoggingAppender">
  <writeSynchronicity>ASYNC</writeSynchronicity>
  <autoPopulateMetadata>true</autoPopulateMetadata>
  <batchingSettings>
    <flowControlSettings>
      <maxOutstandingElementCount>100000</maxOutstandingElementCount>
      <limitExceededBehavior>Ignore</limitExceededBehavior>
    </flowControlSettings>
  </batchingSettings>
</appender>