feat: add support for the VectorValue type #1716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MarkDuckworth
commented
Jun 26, 2024
MarkDuckworth
commented
- Adds class VectorValue
- Supports reading and writing vector values
- Vector search not included
product-auto-label
bot
added
size: l
…oogleapis/java-firestore into markduckworth/vectorvalue-type
…oogleapis/java-firestore into markduckworth/vectorvalue-type
tom-andersen
requested changes
Jun 27, 2024
Contributor
tom-andersen
left a comment
tom-andersen
left a comment
There was a problem hiding this comment.
Overall, this looks good.
I have a few suggestions and questions.
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Order.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/UserDataConverter.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Order.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Order.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/UserDataConverter.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryWatchTest.java
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/VectorValue.java
Outdated
Show resolved
Hide resolved
…s/java-firestore into markduckworth/vectorvalue-type
MarkDuckworth
added
the
do not merge
MarkDuckworth
removed
the
do not merge
wu-hui
approved these changes
Aug 8, 2024
MarkDuckworth
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
MarkDuckworth
changed the title
tom-andersen
approved these changes
Aug 12, 2024
This was referenced Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.