Refactor: refactor grpc query splitter and datastore helper. #1674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
cindy-peng
changed the title
cindy-peng
changed the title
kevkim-codes
approved these changes
Dec 23, 2024
cindy-peng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new Gapic upgrade change, we are deprecating handwritten HTTP Datastore module datastore-v1-proto-client since it will be replaced with auto generated gRPC code.
QuerySplitteris a class in datastore-v1-proto-client which is still used by Beam team. We want to refactor QuerySplitter and its related helper classes including DatatoreHelper.java into a new modulegoogle-cloud-datastore-utilsin google-cloud-datastore so they will continue to be available for our customers while we deprecate datastore-v1-proto-client module.For more details about the design decision, please refer here.