Post #4350 cleanup: Missed a rename of a test helper due to concurrent merges #4389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happened because googleapis#4350 was sent before googleapis#4355 was merged.
googlebot
added
the
cla: yes
dhermes
changed the title
theacodes
approved these changes
Nov 13, 2017
Contributor
Author
|
I merge before CI essentially to unbreak all downstream merges to master. |
chemelnucfin
pushed a commit
to chemelnucfin/google-cloud-python
that referenced
this pull request
Nov 15, 2017
This happened because googleapis#4350 was sent before googleapis#4355 was merged.
chemelnucfin
pushed a commit
to chemelnucfin/google-cloud-python
that referenced
this pull request
Nov 15, 2017
This happened because googleapis#4350 was sent before googleapis#4355 was merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened because #4350 was sent before #4355 was merged.
/cc @alixhami This may have been avoidable (e.g. with a rebase) but since there were no changes needed in the review, it's likely that this was just unavoidable (except for superhumans).