Skip to content

Conversation

@theacodes
Copy link
Contributor

Closes #4233

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2017
Copy link
Contributor

@dhermes dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I love deletes!

Why did this need to happen?

@theacodes
Copy link
Contributor Author

Why did this need to happen?

Turns out we didn't need this functionality in the first place. I originally added it for parity with gax, as when gax wrapped methods it would also handle wrapping the response with a page iterator. While exploring changing the generator to use api_core, @landrito and I noticed that methods that return operations just construct the operation in the generated method body, so we saw no reason why we couldn't do the same with page iterators.

@theacodes theacodes merged commit 380697d into googleapis:master Oct 25, 2017
@theacodes theacodes deleted the remove-wrap-with-paging branch October 25, 2017 22:48
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants