Skip to content

Increase backoff to fix monitoring system test #3769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukesneeringer merged 4 commits into from
Aug 9, 2017
Merged

Increase backoff to fix monitoring system test #3769

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2a8f00
Increase monitoring system test backoff
liyanhui1228 Aug 8, 2017
6b62a1d
Fix monitoring system test
liyanhui1228 Aug 8, 2017
cb01f8d
Fix stuff
liyanhui1228 Aug 8, 2017
bde35e9
Fix stuff
liyanhui1228 Aug 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions monitoring/tests/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ def test_create_and_delete_metric_descriptor(self):
retry_500(descriptor.create)()
retry_404_500(descriptor.delete)()

@RetryErrors(exception=BadRequest, max_tries=2)
def test_write_point(self):
METRIC_TYPE = ('custom.googleapis.com/tmp/system_test_example' +
unique_resource_id())
Expand All @@ -202,14 +203,19 @@ def test_write_point(self):
retry_500(client.write_point)(metric, resource, VALUE)

def _query_timeseries_with_retries():
MAX_RETRIES = 10
MAX_RETRIES = 6

def _has_timeseries(result):
return len(list(result)) > 0

retry_result = RetryResult(_has_timeseries,
max_tries=MAX_RETRIES)(client.query)
return RetryErrors(BadRequest, max_tries=MAX_RETRIES)(retry_result)
retry_result = RetryResult(
_has_timeseries,
max_tries=MAX_RETRIES,
backoff=3)(client.query)
return RetryErrors(
BadRequest,
max_tries=MAX_RETRIES,
backoff=3)(retry_result)

query = _query_timeseries_with_retries()(METRIC_TYPE, minutes=5)
timeseries_list = list(query)
Expand Down