Add basic system test for error reporting #3336
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
waprin
changed the title
dhermes
reviewed
Apr 27, 2017
| session.install('.') | ||
|
|
||
| # Run py.test against the system tests. | ||
| session.run('py.test', '-vvv', 'tests/system.py') |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| # Install all test dependencies, then install this package into the | ||
| # virtualenv's dist-packages. | ||
| session.install('.') |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| try: | ||
| raise NameError | ||
| except NameError: | ||
| client.report_exception() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Closing this in light of #3348 |
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
…Platform/python-docs-samples#3336) Co-authored-by: Leah E. Cole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the bare minimal system test that just makes a client call, it did go red before the scope fix at least.
Can add more asserts but need to add more code to authenticate a separate gax client to list errors, can add that to this PR or a new one.
Fixes #3335