Skip to content

Fix build failing with float precision mismatch #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukesneeringer merged 4 commits into from
Feb 14, 2017
Merged

Fix build failing with float precision mismatch #3002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78d5ebb
Switch failing floats to 1/8.
daspecster Feb 13, 2017
6fe8537
Missed one.
daspecster Feb 13, 2017
a589fb4
More interesting float values.
daspecster Feb 13, 2017
7c9cfd0
Missed one.
daspecster Feb 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions speech/unit_tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,10 +297,10 @@ def test_sync_recognize_with_gax(self):

alternatives = [{
'transcript': 'testing 1 2 3',
'confidence': 0.9224355,
'confidence': 0.740234375,
}, {
'transcript': 'testing 4 5 6',
'confidence': 0.0123456,
'confidence': 0.6396484375,
}]
result = _make_result(alternatives)

Expand Down Expand Up @@ -500,19 +500,19 @@ def test_stream_recognize_interim_results(self):

alternatives = [{
'transcript': 'testing streaming 1 2 3',
'confidence': 0.9224355,
'confidence': 0.5888671875,
}, {
'transcript': 'testing streaming 4 5 6',
'confidence': 0.0123456,
'confidence': 0.28125,
}]
first_response = _make_streaming_response(
_make_streaming_result([], is_final=False, stability=0.122435))
_make_streaming_result([], is_final=False, stability=0.314453125))
second_response = _make_streaming_response(
_make_streaming_result(alternatives, is_final=False,
stability=0.1432343))
stability=0.28125))
last_response = _make_streaming_response(
_make_streaming_result(alternatives, is_final=True,
stability=0.9834534))
stability=0.4375))
responses = [first_response, second_response, last_response]

channel_args = []
Expand Down Expand Up @@ -542,8 +542,8 @@ def speech_api(channel=None):
self.assertIsInstance(results[0], StreamingSpeechResult)
self.assertEqual(results[0].alternatives, [])
self.assertFalse(results[0].is_final)
self.assertEqual(results[0].stability, 0.122435)
self.assertEqual(results[1].stability, 0.1432343)
self.assertEqual(results[0].stability, 0.314453125)
self.assertEqual(results[1].stability, 0.28125)
self.assertFalse(results[1].is_final)
self.assertEqual(results[1].transcript,
results[1].alternatives[0].transcript,
Expand All @@ -556,7 +556,7 @@ def speech_api(channel=None):
self.assertEqual(results[1].alternatives[1].confidence,
alternatives[1]['confidence'])
self.assertTrue(results[2].is_final)
self.assertEqual(results[2].stability, 0.9834534)
self.assertEqual(results[2].stability, 0.4375)
self.assertEqual(results[2].transcript,
results[2].alternatives[0].transcript,
alternatives[0]['transcript'])
Expand All @@ -580,10 +580,10 @@ def test_stream_recognize(self):

alternatives = [{
'transcript': 'testing streaming 1 2 3',
'confidence': 0.9224355,
'confidence': 0.4375,
}, {
'transcript': 'testing streaming 4 5 6',
'confidence': 0.0123456,
'confidence': 0.84375,
}]

first_response = _make_streaming_response(
Expand Down
6 changes: 3 additions & 3 deletions vision/unit_tests/test_annotations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def _make_pb_entity():
description = 'testing 1 2 3'
locale = 'US'
mid = 'm/w/45342234'
score = 0.235434231
score = 0.390625

entity_annotation = image_annotator_pb2.EntityAnnotation(
mid=mid,
Expand Down Expand Up @@ -108,7 +108,7 @@ def test_it(self):
description = 'testing 1 2 3'
locale = 'US'
mid = 'm/w/45342234'
score = 0.235434231
score = 0.390625
entity_annotation = _make_pb_entity()
entities = self._call_fut([entity_annotation])
self.assertEqual(len(entities), 1)
Expand Down Expand Up @@ -183,7 +183,7 @@ def test_it(self):
description = 'testing 1 2 3'
locale = 'US'
mid = 'm/w/45342234'
score = 0.235434231
score = 0.390625
entity_annotation = _make_pb_entity()

image_response = image_annotator_pb2.AnnotateImageResponse(
Expand Down
2 changes: 1 addition & 1 deletion vision/unit_tests/test_entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def test_logo_pb_annotation(self):
description = 'testing 1 2 3'
locale = 'US'
mid = 'm/w/45342234'
score = 0.235434231
score = 0.875
entity_annotation = image_annotator_pb2.EntityAnnotation()
entity_annotation.mid = mid
entity_annotation.locale = locale
Expand Down