Skip to content

Remove invalid chunk validation #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 4 commits into from
Feb 14, 2017
Merged

Remove invalid chunk validation #2992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a37c41a
Remove invalid chunk validation
garye Feb 9, 2017
6a7942d
remove invalid test case
garye Feb 13, 2017
32cec25
fix spacing
garye Feb 13, 2017
4c59daa
update whitespace
garye Feb 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions bigtable/google/cloud/bigtable/row_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,8 +366,6 @@ def _validate_chunk_row_in_progress(self, chunk):
"""Helper for :meth:`_validate_chunk`"""
assert self.state == self.ROW_IN_PROGRESS
self._validate_chunk_status(chunk)
if not chunk.HasField('commit_row') and not chunk.reset_row:
_raise_if(not chunk.timestamp_micros or not chunk.value)
_raise_if(chunk.row_key and
chunk.row_key != self._row.row_key)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

_raise_if(chunk.HasField('family_name') and
Expand Down
14 changes: 0 additions & 14 deletions bigtable/unit_tests/test_row_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,20 +416,6 @@ def test_invalid_empty_chunk(self):
with self.assertRaises(InvalidChunk):
prd.consume_next()

def test_invalid_empty_second_chunk(self):
from google.cloud.bigtable.row_data import InvalidChunk

chunks = _generate_cell_chunks(['', ''])
first = chunks[0]
first.row_key = b'RK'
first.family_name.value = 'A'
first.qualifier.value = b'C'
response = _ReadRowsResponseV2(chunks)
iterator = _MockCancellableIterator(response)
prd = self._make_one(iterator)
with self.assertRaises(InvalidChunk):
prd.consume_next()


class TestPartialRowsData_JSON_acceptance_tests(unittest.TestCase):

Expand Down