Rename document_from_url to document_from_gcs_url.
#2986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
reviewed
Feb 6, 2017
| @functools.wraps(document_from_gcs_url) | ||
| def document_from_url(self, *args, **kwargs): | ||
| """Deprecated equivalent to document_from_gcs_url. | ||
| (Deprecated on 2017-02-06.) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
approved these changes
Feb 6, 2017
lukesneeringer
commented
Feb 6, 2017
| client = self._make_one(credentials=creds, http=object()) | ||
|
|
||
| Client = self._get_target_class() | ||
| with mock.patch.object(Client, 'document_from_gcs_url') as dfgu: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
19 tasks
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
This does a rename requested by the NL team.
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
This does a rename requested by the NL team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was requested by the NL team, since we only accept GCS URLs, and
document_from_urlimplies anything.Rather than a flat rename, I am having the original method warn a
DeprecationWarning. We do not really have a process for deprecating or keeping up with them, so for the time being I am noting the date in the docstring.