Add storage.blob property time_created (timeCreated) #2933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
daspecster
suggested changes
Jan 12, 2017
| """ | ||
| value = self._properties.get('timeCreated') | ||
| if value is not None: | ||
| return _rfc3339_to_datetime(value) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
@bivald Thanks! Looks like the test doesn't cover the |
Contributor
Author
|
@daspecster I've added the missing unit test as well as fixed the lint-error, I realised that I've put the unit test in the wrong order so I've fixed that as well. |
daspecster
approved these changes
Jan 13, 2017
Contributor
|
Thanks @bivald! |
Contributor
Author
|
Thank you :) |
19 tasks
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Add storage.blob property time_created (timeCreated) (googleapis#2933)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a super small PR which adds storage.blob property time_created (timeCreated) which I found myself needing recently. It's basically a copy paste of time_deleted. Unit test added.