Switch NL from v1beta1 to v1. Fixes #2747. #2798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
approved these changes
Dec 2, 2016
Contributor
dhermes
left a comment
dhermes
left a comment
There was a problem hiding this comment.
Wow that was easy! Thanks a lot
| api_response = self.client._connection.api_request( | ||
| method='POST', path='analyzeSyntax', data=data) | ||
| return [Token.from_api_repr(token) | ||
| for token in api_response['tokens']] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
language/unit_tests/test_document.py
Outdated
| 'proper': 'PROPER', | ||
| 'reciprocity': 'RECIPROCITY_UNKNOWN', | ||
| 'tense': 'TENSE_UNKNOWN', | ||
| 'voice': 'VOICE_UNKNOWN', |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM |
Contributor
Author
|
Is there a set release schedule? What's the ETA on getting a new version of |
Contributor
|
I'll be releasing this afternoon, thanks for checking in |
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Switch NL from v1beta1 to v1. Fixes googleapis#2747.
parthea
pushed a commit
that referenced
this pull request
Jul 6, 2023
Switch NL from v1beta1 to v1. Fixes #2747.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.