Use PEP8 names in test helper methods #2710
Conversation
googlebot
added
the
cla: yes
|
@dhermes was this scripted at all? Also, my internet may be slow or something but I can't even get the files view to load ATM. |
It's probably not your internet, just the browser failing because of too much memory needed. May be easier to check out my branch locally.
See my comment |
|
@dhermes oh I didn't expand the commit messages. That's cool. |
|
What would it take to enable We could just update the regex that |
|
Also this LGTM after the rebase and travs going green. |
I'd imagine a lot. We could probably get some mileage out of tweaking regexes. |
Done via: $ git grep -l 'def _getTargetClass(self)' | \ > xargs sed -i s/'def _getTargetClass(self)'/'@staticmethod\n def _get_target_class()'/g
Done via: $ git grep -l _getTargetClass | \ > xargs sed -i s/_getTargetClass/_get_target_class/g
Done via: $ git grep -l _makeOne | \ > xargs sed -i s/_makeOne/_make_one/g
Done via: $ git grep -l _callFUT | \ > xargs sed -i s/_callFUT/_call_fut/g
dhermes
force-pushed
the
pep8-names-in-tests
branch
from
34b1e17 to
affb4a3
Compare
|
Just rebased. Will merge if/when at least one CI goes green. |
Use PEP8 names in test helper methods
Use PEP8 names in test helper methods
Use PEP8 names in test helper methods
Use PEP8 names in test helper methods
4 participants
From discussion with @tseaver in #2681
Most of this PR was created from the command line, see the commit messages for the commands used to create the commits.
I also wanted to turn off the
no-self-usedisable in the test Pylint RC but it had too many offenders left to put in this PR.