Skip to content

Clean up async docs and unify for future GAPIC async. #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daspecster merged 1 commit into from
Oct 29, 2016
Merged

Clean up async docs and unify for future GAPIC async. #2638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions docs/speech-usage.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,12 @@ See: `Speech Asynchronous Recognize`_
... operation.poll() # API call
>>> operation.complete
True
>>> operation.results[0].transcript
>>> for result in operation.results:
... print('=' * 20)
... print(result.transcript)
... print(result.confidence)
====================
'how old is the Brooklyn Bridge'
>>> operation.results[0].confidence
0.98267895


Expand Down
5 changes: 3 additions & 2 deletions speech/google/cloud/speech/operation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,9 @@ def _update(self, response):
raw_results = response.get('response', {}).get('results', None)

This comment was marked as spam.

Sign in to view

results = []
if raw_results:
for result in raw_results[0]['alternatives']:
results.append(Transcript.from_api_repr(result))
for result in raw_results:
for alternative in result['alternatives']:
results.append(Transcript.from_api_repr(alternative))

This comment was marked as spam.

Sign in to view

if metadata:
self._metadata = Metadata.from_api_repr(metadata)

Expand Down
6 changes: 4 additions & 2 deletions speech/unit_tests/test_operation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def test_ctor_defaults(self):

def test_from_api_repr(self):
from unit_tests._fixtures import OPERATION_COMPLETE_RESPONSE
from google.cloud.speech.operation import Transcript
from google.cloud.speech.transcript import Transcript
from google.cloud.speech.metadata import Metadata
RESPONSE = OPERATION_COMPLETE_RESPONSE

Expand All @@ -46,10 +46,12 @@ def test_from_api_repr(self):
self.assertEqual('123456789', operation.name)
self.assertTrue(operation.complete)

self.assertEqual(len(operation.results), 1)
self.assertIsInstance(operation.results[0], Transcript)
self.assertEqual(operation.results[0].transcript,
'how old is the Brooklyn Bridge')
self.assertEqual(operation.results[0].confidence, 0.98267895)
self.assertEqual(operation.results[0].confidence,
0.98267895)
self.assertTrue(operation.complete)
self.assertIsInstance(operation.metadata, Metadata)
self.assertEqual(operation.metadata.progress_percent, 100)
Expand Down