Skip to content

Add eventual consistency check for storage list_blobs() #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhermes merged 1 commit into from
Aug 24, 2016
Merged

Add eventual consistency check for storage list_blobs() #2181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions system_tests/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

from system_test_utils import unique_resource_id
from retry import RetryErrors
from retry import RetryResult


retry_429 = RetryErrors(exceptions.TooManyRequests)
Expand Down Expand Up @@ -225,8 +226,16 @@ def tearDownClass(cls):
blob.delete()

def test_list_files(self):
all_blobs = list(self.bucket.list_blobs())
self.assertEqual(len(all_blobs), len(self.FILENAMES))
def _all_in_list(blobs):
return len(blobs) == len(self.FILENAMES)

def _all_blobs():
return list(self.bucket.list_blobs())

retry = RetryResult(_all_in_list)
all_blobs = retry(_all_blobs)()
self.assertEqual(sorted(blob.name for blob in all_blobs),
sorted(self.FILENAMES))

def test_paginate_files(self):
truncation_size = 1
Expand Down