Skip to content

system_test nox sessions shouldn't ALWAYS "pass" with no config #3248

@dhermes

Description

@dhermes

Was just chatting with @daspecster and running nox locally gives no real indication that the system tests did nothing.

Rather than checking for GOOGLE_APPLICATION_CREDENTIALS and saying "nothing to see here" we should probably instead do:

  1. Bail without failing if in CI and not in a push build (e.g.)
  2. If we've made it PAST the bail out (i.e. not on CI or in CI on a merge build) than FAIL THE TEST if GOOGLE_APPLICATION_CREDENTIALS is unset

Metadata

Metadata

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.testing

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions