This repository was archived by the owner on Dec 10, 2025. It is now read-only.
Add kokoro #61
Merged
Add kokoro #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
busunkim96
commented
Jan 25, 2019
busunkim96
commented
- Remove Appveyor
- Remove Coveralls
- Use nox
googlebot
added
the
cla: yes
sduskis
suggested changes
Jan 25, 2019
sduskis
left a comment
sduskis
left a comment
There was a problem hiding this comment.
There's a lot going on in this PR. Is it possible to split out the formatting changes from the kokoro changes?
Contributor
Author
|
@sduskis That sounds good, I'll separate out the PRs. |
busunkim96
force-pushed
the
add-kokoro
branch
from
b9ee76c to
ad5d131
Compare
busunkim96
force-pushed
the
add-kokoro
branch
from
6d931a1 to
d9cf89b
Compare
busunkim96
force-pushed
the
add-kokoro
branch
from
d9cf89b to
eaf3217
Compare
busunkim96
force-pushed
the
add-kokoro
branch
from
eaf3217 to
6b72f77
Compare
busunkim96
force-pushed
the
add-kokoro
branch
from
e82f0a0 to
080af20
Compare
crwilcox
approved these changes
Feb 2, 2019
Contributor
crwilcox
left a comment
crwilcox
left a comment
There was a problem hiding this comment.
I pushed a few changes post my changes. Turns out my encoding tests aren't going to fail under python2 since it doesn't care if the strings are bytes or not. Also changed the targets in noxfile to match our other python projects.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.