-
Notifications
You must be signed in to change notification settings - Fork 23
Release google-cloud-python-happybase 0.32.0 #56
Release google-cloud-python-happybase 0.32.0 #56
Conversation
|
@crwilcox, it looks like there's a failing unit test. I'm going to try to rerun, For posterity, here's the failure from TestBatch.test_send:
This needs to be a comparison of sets rather than lists. |
|
@sduskis Well, that is a thing. This PR should result in no code changes. That means we have had this failing in master :( |
tseaver
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Track merge of PR #53.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
5c55683 to
cea9097
Compare
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
@crwilcox The lint failure is real: |
|
Release should block on merge of #57, which fixes the real (not style) bug revealed by the lint failure. |
Co-Authored-By: crwilcox <[email protected]>
cea9097 to
ed7b633
Compare
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
This pull request was generated using releasetool.