Skip to content
This repository was archived by the owner on Dec 10, 2025. It is now read-only.

Conversation

@crwilcox
Copy link
Contributor

This pull request was generated using releasetool.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 18, 2018
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 18, 2018
@sduskis
Copy link

sduskis commented Dec 18, 2018

@crwilcox, it looks like there's a failing unit test. I'm going to try to rerun,

For posterity, here's the failure from TestBatch.test_send:

   self.assertEqual(table._low_level_table.rows_mutate,
                   [row1, row2])

This needs to be a comparison of sets rather than lists.

@crwilcox
Copy link
Contributor Author

@sduskis Well, that is a thing. This PR should result in no code changes. That means we have had this failing in master :(

@crwilcox crwilcox requested a review from tseaver December 18, 2018 21:43
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Track merge of PR #53.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 18, 2018
@crwilcox crwilcox added the cla: yes This human has signed the Contributor License Agreement. label Dec 18, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Dec 18, 2018
@tseaver tseaver force-pushed the release-google-cloud-python-happybase-2018.12.17 branch from 5c55683 to cea9097 Compare December 19, 2018 15:59
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Dec 19, 2018
@tseaver
Copy link
Contributor

tseaver commented Dec 19, 2018

@crwilcox I rebased the branch to pick up the unit test fix from #53.

@tseaver
Copy link
Contributor

tseaver commented Dec 19, 2018

@crwilcox The lint failure is real: google.cloud.happybase.pool.Pool.__init__ actually does make an invalid call to google.cloud.happybase.connection._get_instance: its unit tests mock that away.

tseaver added a commit that referenced this pull request Dec 19, 2018
@tseaver
Copy link
Contributor

tseaver commented Dec 19, 2018

Release should block on merge of #57, which fixes the real (not style) bug revealed by the lint failure.

@tseaver tseaver added status: blocked Resolving the issue is dependent on other work. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 19, 2018
tseaver added a commit that referenced this pull request Dec 19, 2018
@tseaver tseaver force-pushed the release-google-cloud-python-happybase-2018.12.17 branch from cea9097 to ed7b633 Compare December 19, 2018 16:37
@crwilcox crwilcox added the cla: yes This human has signed the Contributor License Agreement. label Dec 19, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Dec 19, 2018
@crwilcox crwilcox changed the title Release google-cloud-python-happybase 2018.12.17 Release google-cloud-python-happybase 0.32.0 Dec 19, 2018
@crwilcox crwilcox merged commit 2ef94b9 into master Dec 19, 2018
@crwilcox
Copy link
Contributor Author

@crwilcox crwilcox deleted the release-google-cloud-python-happybase-2018.12.17 branch December 20, 2018 02:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autorelease: tagged cla: yes This human has signed the Contributor License Agreement. status: blocked Resolving the issue is dependent on other work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants