Skip to content

The Road to GA - BigQuery Updates #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dwsupplee merged 7 commits into from
Oct 16, 2017
Merged

The Road to GA - BigQuery Updates #644

dwsupplee merged 7 commits into from
Oct 16, 2017

Conversation

@dwsupplee
Copy link
Contributor

@dwsupplee dwsupplee commented Aug 22, 2017 •
edited
Loading

These changes help us prepare for a GA release of BigQuery. For more details on the work, please refer to the following PRs which have been aggregated here:

#604 - Run query and wait for it to complete
#634 - Add support for etags on bigquery tables and datasets
#640 - Switch to standard SQL by default
#642 - Implement waitUntilComplete and block while waiting for query results
#643 - Generate BigQuery Job ID on client side with optional prefix

Edit: Also now includes #686

/cc @tswast @michaelbausor

@dwsupplee dwsupplee added the api: bigquery Issues related to the BigQuery API. label Aug 22, 2017
@googlebot
Copy link

googlebot commented Aug 22, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 22, 2017
@dwsupplee dwsupplee added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 22, 2017
tswast
tswast reviewed Aug 22, 2017
View reviewed changes
Copy link

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM.

src/BigQuery/BigQueryClient.php Outdated
* in this client.
* }
* @return QueryResults
* @throws \RuntimeException If the maximum number of retries while waiting

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/BigQuery/Job.php
public function cancel(array $options = [])
{
$this->connection->cancelJob($options + $this->identity);
}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 31, 2017
@dwsupplee
Copy link
Contributor Author

dwsupplee commented Aug 31, 2017

@tswast updated based on our discussions in the comments. PTAL when you have a moment, :)

@dwsupplee dwsupplee force-pushed the bigquery branch 2 times, most recently from 9466a53 to 7da67d2 Compare August 31, 2017 23:34
@dwsupplee dwsupplee mentioned this pull request Sep 29, 2017
Merged
@dwsupplee dwsupplee added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 29, 2017
jdpedrie and others added 7 commits October 16, 2017 10:54
@jdpedrie @dwsupplee
Run query and wait for it to complete (#604)
19240c1 
* Run query and wait for it to complete

* Document exception on BigQueryClient::runQuery()

* Update snippet test
@jdpedrie @dwsupplee
Add support for etags on bigquery tables and datasets (#634)
421dfce
@jdpedrie @dwsupplee
[BC Break] Switch to standard SQL by default (#640)
5bd2516 
* Switch to standard SQL by default

* Fix setting of useLegacySql option

* Fix job config logic

* Address code review
@dwsupplee
[BC Break] Implement waitUntilComplete and block while waiting for qu…
de264fe 
…ery results (#642)

* implement waitUntilComplete on job and block waiting for queryResults

* fix getIterator docblock
@jdpedrie @dwsupplee
Generate BigQuery Job ID on client side with optional prefix (#643)
6e13576
@dwsupplee
address code review
f5c0c2c
@dwsupplee
Introduce remaining BigQuery to GA items (#686)
29ce1b9 
* introduce job configuration classes

* update tests/docs and add copy/load

* modify retry logic

* add create on insert logic
@dwsupplee dwsupplee merged commit 04b22d0 into master Oct 16, 2017
@dwsupplee dwsupplee deleted the bigquery branch October 17, 2017 19:23
@jackchuka jackchuka mentioned this pull request Dec 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dwsupplee @googlebot @tswast @jdpedrie