Skip to content

[BC Break] Add requestTimeout option to be shared between REST/gRPC #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dwsupplee merged 3 commits into from
Mar 16, 2017
Merged

[BC Break] Add requestTimeout option to be shared between REST/gRPC #390

dwsupplee merged 3 commits into from
Mar 16, 2017

Conversation

@dwsupplee
Copy link
Contributor

@dwsupplee dwsupplee commented Mar 10, 2017

Closes: #376

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2017
@jdpedrie jdpedrie changed the title Add requestTimeout option to be shared between REST/gRPC [BC Break] Add requestTimeout option to be shared between REST/gRPC Mar 10, 2017
@jdpedrie
Copy link
Contributor

jdpedrie commented Mar 10, 2017

BC Break: renamed httpOptions to restOptions.

@dwsupplee
Copy link
Contributor Author

dwsupplee commented Mar 15, 2017

@jdpedrie rebased! PTAL

@dwsupplee dwsupplee merged commit 06cbd4c into googleapis:master Mar 16, 2017
@dwsupplee dwsupplee deleted the request-timeout branch March 16, 2017 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jdpedrie jdpedrie jdpedrie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dwsupplee @jdpedrie @googlebot