core: ending streams manually is unnecessary, unless they errored #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
Author
|
@leibale would you mind trying this out? |
Contributor
|
listen to end, finish or complete? |
Contributor
|
it's working with |
Contributor
Author
|
Yep, it should work like: file.createReadStream()
.on('complete', function() {}) // File fully read
.pipe(fs.createWriteStream('./file'))
.on('finish', function() {}) // File fully written |
Contributor
|
working like a charm, thanks :) pls add |
callmehiphop
added a commit
that referenced
this pull request
Aug 18, 2015
…ms-with-error core: ending streams manually is unnecessary, unless they errored
Contributor
|
Sweet, thanks! @leibale this has been merged in but we still need to do a release. I think we have one coming very soon! |
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 468790263 Source-Link: googleapis/googleapis@873ab45 Source-Link: googleapis/googleapis-gen@cb6f37a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
Merged
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
* fix: use @grpc/grpc-js v1.0.0, pass grpc options properly * docs: pr feedback
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
gRPC options are weird. Regular gRPC options are prefixed `grpc.` and should be passed down as `grpc.*`, while the three known `grpc-gcp` options should be passed without a prefix. This partially rolls back my refactor in #809 to make `grpc-gcp` work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #805
This goes over all of our streams and only manually ends or destroys them when it's because of an error. It turns out, calling
destroywas akin to smashing a wrecking ball through a user's pipeline.endis usually preferred for its gracefulness, but we don't appear to need either. Streams end up "ending" themselves when they're ready, and they usually know best when that is.