Skip to content

system tests: search: delete documents individually #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
callmehiphop merged 1 commit into from
Aug 6, 2015
Merged

system tests: search: delete documents individually #784

callmehiphop merged 1 commit into from
Aug 6, 2015

Conversation

@stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented Aug 6, 2015

RE: #775 (comment)

The Search API doesn't allow indexes to be deleted. Instead, you can delete all of the documents within them. That's what we were doing previously, but as the amount of created Documents grows, it's taking an excessive amount of time to fetch, then iteratively delete each one that exists.

This PR changes the tests to create/delete a document, instead of letting the before/after hooks handle it the old way.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 6, 2015
@stephenplusplus stephenplusplus mentioned this pull request Aug 6, 2015
Closed
@jgeewax
Copy link
Contributor

jgeewax commented Aug 6, 2015 via email

@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Aug 6, 2015

Yep, thanks. Will fix that in the first post.

callmehiphop
callmehiphop reviewed Aug 6, 2015
View reviewed changes
system-test/search.js

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

callmehiphop added a commit that referenced this pull request Aug 6, 2015
@callmehiphop
Merge pull request #784 from stephenplusplus/spp--search-tests
eaf753e 
system tests: search: delete documents individually
@callmehiphop callmehiphop merged commit eaf753e into googleapis:master Aug 6, 2015
@callmehiphop
Copy link
Contributor

callmehiphop commented Aug 6, 2015

Travis will be so happy! (I hope!)

@quartzmo
Copy link
Member

quartzmo commented Oct 5, 2015

@stephenplusplus We are trying to follow your work on Search, as we're about to start on it for the Ruby lib. Do you think you could create a search label and add it to issues like this one?

@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented Oct 5, 2015

@quartzmo sure, I found a few: https://github.com/GoogleCloudPlatform/gcloud-node/issues?q=label%3Asearch+is%3Aclosed I don't think we've had that many. Let me know if any questions come up.

@sofisl sofisl mentioned this pull request Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 10, 2023
@gcf-owl-bot
fix: regenerated protos JS and TS definitions (#784)
986f27b 
samples: pull in latest typeless bot, clean up some comments

Source-Link: https://togithub.com/googleapis/synthtool/commit/0a68e568b6911b60bb6fd452eba4848b176031d8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:5b05f26103855c3a15433141389c478d1d3fe088fb5d4e3217c4793f6b3f245e
sofisl pushed a commit that referenced this pull request Jan 10, 2023
@release-please
chore(main): release 4.3.0 (#778)
2512765 
🤖 I have created a release *beep* *boop*
---


## [4.3.0](https://togithub.com/googleapis/nodejs-dlp/compare/v4.2.0...v4.3.0) (2023-01-06)


### Features

* ExcludeByHotword added as an ExclusionRule type, NEW_ZEALAND added as a LocationCategory value ([5b54b2e](https://togithub.com/googleapis/nodejs-dlp/commit/5b54b2e9c63acee3022089d9fb94d8b1907c1eb2))


### Bug Fixes

* Deprecate extra field to avoid confusion ([#777](https://togithub.com/googleapis/nodejs-dlp/issues/777)) ([f6a7ebd](https://togithub.com/googleapis/nodejs-dlp/commit/f6a7ebde9f78440600ac178a568e3fe79ccfadc2))
* **deps:** Use google-gax v3.5.2 ([#781](https://togithub.com/googleapis/nodejs-dlp/issues/781)) ([3601ed8](https://togithub.com/googleapis/nodejs-dlp/commit/3601ed84fa97958ca52bdc8d5620317f1a4a1de5))
* Regenerated protos JS and TS definitions ([#784](https://togithub.com/googleapis/nodejs-dlp/issues/784)) ([fa109f0](https://togithub.com/googleapis/nodejs-dlp/commit/fa109f05c3a29473a330e96b20e89480fb89496e))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this pull request Jan 17, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 17, 2023
@munkhuushmgl
fix: mocha tests (#784)
f334bf0
sofisl pushed a commit that referenced this pull request Jan 24, 2023
@gcf-owl-bot
fix: failing tests for LRO check methods (#784)
b81427e 
* fix: failing tests for LRO check methods

Updated gapic-generator-typescript to v2.1.1.

Committer: @alexander-fenster
PiperOrigin-RevId: 387841814

Source-Link: googleapis/googleapis@f973532

Source-Link: googleapis/googleapis-gen@acb489d

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Jan 24, 2023
@release-please
chore: release 4.5.6 (#785)
7b17f0a 
🤖 I have created a release \*beep\* \*boop\*
---
### [4.5.6](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.5...v4.5.6) (2021-08-02)


### Bug Fixes

* failing tests for LRO check methods ([#784](https://www.github.com/googleapis/nodejs-speech/issues/784)) ([08e4276](https://www.github.com/googleapis/nodejs-speech/commit/08e4276a39a74a45300041278dc3c63602971c10))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this pull request Jan 25, 2023
@gcf-owl-bot
fix: failing tests for LRO check methods (#784)
390ed67 
* fix: failing tests for LRO check methods

Updated gapic-generator-typescript to v2.1.1.

Committer: @alexander-fenster
PiperOrigin-RevId: 387841814

Source-Link: googleapis/googleapis@f973532

Source-Link: googleapis/googleapis-gen@acb489d

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Jan 25, 2023
@release-please
chore: release 4.5.6 (#785)
1f1ebbd 
🤖 I have created a release \*beep\* \*boop\*
---
### [4.5.6](https://www.github.com/googleapis/nodejs-speech/compare/v4.5.5...v4.5.6) (2021-08-02)


### Bug Fixes

* failing tests for LRO check methods ([#784](https://www.github.com/googleapis/nodejs-speech/issues/784)) ([08e4276](https://www.github.com/googleapis/nodejs-speech/commit/08e4276a39a74a45300041278dc3c63602971c10))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025
@renovate-bot
chore(deps): update dependency karma to v5 (#784)
eefad91 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [karma](http://karma-runner.github.io/) ([source](https://togithub.com/karma-runner/karma)) | devDependencies | major | [`^4.1.0` -> `^5.0.0`](https://renovatebot.com/diffs/npm/karma/4.4.1/5.0.9) |

---

### Release Notes

<details>
<summary>karma-runner/karma</summary>

### [`v5.0.9`](https://togithub.com/karma-runner/karma/blob/master/CHANGELOG.md#&#8203;509-httpsgithubcomkarma-runnerkarmacomparev508v509-2020-05-19)

[Compare Source](https://togithub.com/karma-runner/karma/compare/v5.0.8...v5.0.9)

##### Bug Fixes

-   **dependencies:** update to safe version of http-proxy ([#&#8203;3519](https://togithub.com/karma-runner/karma/issues/3519)) ([00347bb](https://togithub.com/karma-runner/karma/commit/00347bb204c8c87e1096679af4634032d6600b67)), closes [#&#8203;3510](https://togithub.com/karma-runner/karma/issues/3510)

### [`v5.0.8`](https://togithub.com/karma-runner/karma/blob/master/CHANGELOG.md#&#8203;508-httpsgithubcomkarma-runnerkarmacomparev507v508-2020-05-18)

[Compare Source](https://togithub.com/karma-runner/karma/compare/v5.0.7...v5.0.8)

##### Bug Fixes

-   **dependencies:** update and unlock socket.io dependency ([#&#8203;3513](https://togithub.com/karma-runner/karma/issues/3513)) ([b60391f](https://togithub.com/karma-runner/karma/commit/b60391fbddcfa5f8c50b6ac6e3c8d8d845258a56))
-   **dependencies:** update to latest log4js major ([#&#8203;3514](https://togithub.com/karma-runner/karma/issues/3514)) ([47f1cb2](https://togithub.com/karma-runner/karma/commit/47f1cb222ee0921defbe313b694da3288a894fec))

### [`v5.0.7`](https://togithub.com/karma-runner/karma/blob/master/CHANGELOG.md#&#8203;507-httpsgithubcomkarma-runnerkarmacomparev506v507-2020-05-16)

[Compare Source](https://togithub.com/karma-runner/karma/compare/v5.0.6...v5.0.7)

##### Bug Fixes

-   detect type for URLs with query parameter or fragment identifier ([#&#8203;3509](https://togithub.com/karma-runner/karma/issues/3509)) ([f399063](https://togithub.com/karma-runner/karma/commit/f399063d1bc8954dba74166ea3dabef2fe376ae4)), closes [#&#8203;3497](https://togithub.com/karma-runner/karma/issues/3497)

### [`v5.0.6`](https://togithub.com/karma-runner/karma/blob/master/CHANGELOG.md#&#8203;506-httpsgithubcomkarma-runnerkarmacomparev505v506-2020-05-16)

[Compare Source](https://togithub.com/karma-runner/karma/compare/v5.0.5...v5.0.6)

##### Bug Fixes

-   **dependencies:** update production dependencies ([#&#8203;3512](https://togithub.com/karma-runner/karma/issues/3512)) ([0cd696f](https://togithub.com/karma-runner/karma/commit/0cd696fe91f2616f6646ea5c67cc44b49d7e941a))

### [`v5.0.5`](https://togithub.com/karma-runner/karma/blob/master/CHANGELOG.md#&#8203;505-httpsgithubcomkarma-runnerkarmacomparev504v505-2020-05-07)

[Compare Source](https://togithub.com/karma-runner/karma/compare/v5.0.4...v5.0.5)

##### Bug Fixes

-   **cli:** restore command line help contents ([#&#8203;3502](https://togithub.com/karma-runner/karma/issues/3502)) ([e99da31](https://togithub.com/karma-runner/karma/commit/e99da316a2d3f875f45baf4e985e521a2fcc755f)), closes [#&#8203;3474](https://togithub.com/karma-runner/karma/issues/3474)

### [`v5.0.4`](https://togithub.com/karma-runner/karma/blob/master/CHANGELOG.md#&#8203;504-httpsgithubcomkarma-runnerkarmacomparev503v504-2020-04-30)

[Compare Source](https://togithub.com/karma-runner/karma/compare/v5.0.3...v5.0.4)

##### Bug Fixes

-   **browser:** make sure that empty results array is still recognized ([#&#8203;3486](https://togithub.com/karma-runner/karma/issues/3486)) ([fa95fa3](https://togithub.com/karma-runner/karma/commit/fa95fa3c917470fa4b9ad736287379d1e9ebb350))

### [`v5.0.3`](https://togithub.com/karma-runner/karma/blob/master/CHANGELOG.md#&#8203;503-httpsgithubcomkarma-runnerkarmacomparev502v503-2020-04-29)

[Compare Source](https://togithub.com/karma-runner/karma/compare/v5.0.2...v5.0.3)

##### Bug Fixes

-   **client:** flush resultsBuffer on engine upgrade ([#&#8203;3212](https://togithub.com/karma-runner/karma/issues/3212)) ([e44ca94](https://togithub.com/karma-runner/karma/commit/e44ca944fe94ae455cd6dc45d9985a6d9fb94754)), closes [#&#8203;3211](https://togithub.com/karma-runner/karma/issues/3211)

### [`v5.0.2`](https://togithub.com/karma-runner/karma/blob/master/CHANGELOG.md#&#8203;502-httpsgithubcomkarma-runnerkarmacomparev501v502-2020-04-16)

[Compare Source](https://togithub.com/karma-runner/karma/compare/v5.0.1...v5.0.2)

##### Bug Fixes

-   **ci:** stop the proxy before killing the child, handle errors ([#&#8203;3472](https://togithub.com/karma-runner/karma/issues/3472)) ([abe9af6](https://togithub.com/karma-runner/karma/commit/abe9af616f7a08f3c64cc06f6a68bd5f9c941133)), closes [#&#8203;3464](https://togithub.com/karma-runner/karma/issues/3464)

### [`v5.0.1`](https://togithub.com/karma-runner/karma/blob/master/CHANGELOG.md#&#8203;501-httpsgithubcomkarma-runnerkarmacomparev500v501-2020-04-10)

[Compare Source](https://togithub.com/karma-runner/karma/compare/v5.0.0...v5.0.1)

##### Bug Fixes

-   **file-list:** do not define fs.statAsync ([#&#8203;3467](https://togithub.com/karma-runner/karma/issues/3467)) ([55a59e7](https://togithub.com/karma-runner/karma/commit/55a59e70017af79d6f3c170d87d808acc8e21faf))

### [`v5.0.0`](https://togithub.com/karma-runner/karma/blob/master/CHANGELOG.md#&#8203;500-httpsgithubcomkarma-runnerkarmacomparev441v500-2020-04-09)

[Compare Source](https://togithub.com/karma-runner/karma/compare/v4.4.1...v5.0.0)

##### Bug Fixes

-   install semantic-release as a regular dev dependency ([#&#8203;3455](https://togithub.com/karma-runner/karma/issues/3455)) ([1eaf35e](https://togithub.com/karma-runner/karma/commit/1eaf35e1d616a2ef21dd00d843552f189fbc7c94))
-   **ci:** echo travis env that gates release after_success ([#&#8203;3446](https://togithub.com/karma-runner/karma/issues/3446)) ([b8b2ed8](https://togithub.com/karma-runner/karma/commit/b8b2ed81e595baf0337c9628a736494b9f2c91c1))
-   **ci:** poll every 10s to avoid rate limit. ([#&#8203;3388](https://togithub.com/karma-runner/karma/issues/3388)) ([91e7e00](https://togithub.com/karma-runner/karma/commit/91e7e00b29db95ea7209f60c07431b10ab597b02))
-   **middleware/runner:** handle file list rejections ([#&#8203;3400](https://togithub.com/karma-runner/karma/issues/3400)) ([80febfb](https://togithub.com/karma-runner/karma/commit/80febfb53a7d041bdcbcffef617e53cdc2d8dd66)), closes [#&#8203;3396](https://togithub.com/karma-runner/karma/issues/3396) [#&#8203;3396](https://togithub.com/karma-runner/karma/issues/3396)
-   **server:** cleanup import of the removed method ([#&#8203;3439](https://togithub.com/karma-runner/karma/issues/3439)) ([cb1bcbf](https://togithub.com/karma-runner/karma/commit/cb1bcbf0b33c8b14a823f7c2cfb7003a7d7704e5))
-   **server:** createPreprocessor was removed ([#&#8203;3435](https://togithub.com/karma-runner/karma/issues/3435)) ([5c334f5](https://togithub.com/karma-runner/karma/commit/5c334f5e811c490f49e4e681e38345776b77210a))
-   **server:** detection new MS Edge Chromium ([#&#8203;3440](https://togithub.com/karma-runner/karma/issues/3440)) ([7166ce2](https://togithub.com/karma-runner/karma/commit/7166ce2b965a44c89010271fda908e2d58a10a9a))
-   **server:** replace optimist on yargs lib ([#&#8203;3451](https://togithub.com/karma-runner/karma/issues/3451)) ([ec1e69a](https://togithub.com/karma-runner/karma/commit/ec1e69a2545695ee248f34c26f7c4c2b50439b94)), closes [#&#8203;2473](https://togithub.com/karma-runner/karma/issues/2473)
-   **server:** Report original error message ([#&#8203;3415](https://togithub.com/karma-runner/karma/issues/3415)) ([79ee331](https://togithub.com/karma-runner/karma/commit/79ee331c939b7fb76a826d9216fea5fabc646854)), closes [#&#8203;3414](https://togithub.com/karma-runner/karma/issues/3414)

##### Code Refactoring

-   use native Promise instead of Bluebird ([#&#8203;3436](https://togithub.com/karma-runner/karma/issues/3436)) ([33a069f](https://togithub.com/karma-runner/karma/commit/33a069f8a4c4687cdbe07971cca479d98b262e3f)), closes [/github.com/karma-runner/karma/pull/3060#discussion_r284797390](https://togithub.com//github.com/karma-runner/karma/pull/3060/issues/discussion_r284797390)

##### Continuous Integration

-   drop node 8, adopt node 12 ([#&#8203;3430](https://togithub.com/karma-runner/karma/issues/3430)) ([a673aa8](https://togithub.com/karma-runner/karma/commit/a673aa8ad76f733565498f2aab13fcd720502be1))

##### Features

-   **docs:** document `DEFAULT_LISTEN_ADDR` constant ([#&#8203;3443](https://togithub.com/karma-runner/karma/issues/3443)) ([057d527](https://togithub.com/karma-runner/karma/commit/057d527262f1e258f53985116cba718268f108da)), closes [#&#8203;2479](https://togithub.com/karma-runner/karma/issues/2479)
-   **karma-server:** added log to the server.js for uncaught exception ([#&#8203;3399](https://togithub.com/karma-runner/karma/issues/3399)) ([adc6a66](https://togithub.com/karma-runner/karma/commit/adc6a66943c93185e8481060c3cf4b7416985151))
-   **preprocessor:** obey Pattern.isBinary when set ([#&#8203;3422](https://togithub.com/karma-runner/karma/issues/3422)) ([708ae13](https://togithub.com/karma-runner/karma/commit/708ae133acc233195ea64657cafbb86cbd56f115)), closes [#&#8203;3405](https://togithub.com/karma-runner/karma/issues/3405)

##### BREAKING CHANGES

-   Karma plugins which rely on the fact that Karma uses Bluebird promises may break as Bluebird-specific API is no longer available on Promises returned by the Karma core
-   **server:** Deprecated createPreprocessor removed, karma-browserify &lt; 7 version doesn't work
-   no more testing on node 8.

#### [4.4.1](https://togithub.com/karma-runner/karma/compare/v4.4.0...v4.4.1) (2019-10-18)

##### Bug Fixes

-   **deps:** back to karma-browserstack-launcher 1.4 ([#&#8203;3361](https://togithub.com/karma-runner/karma/issues/3361)) ([1cd87ad](https://togithub.com/karma-runner/karma/commit/1cd87ad))
-   **server:** Add test coverage for config.singleRun true branch. ([#&#8203;3384](https://togithub.com/karma-runner/karma/issues/3384)) ([259be0d](https://togithub.com/karma-runner/karma/commit/259be0d))
-   if preprocessor is async function and doesn't return a content then await donePromise ([#&#8203;3387](https://togithub.com/karma-runner/karma/issues/3387)) ([f91be24](https://togithub.com/karma-runner/karma/commit/f91be24))

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/gax-nodejs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stephenplusplus @jgeewax @callmehiphop @quartzmo @googlebot