docs: added local version of angular-highlightjs #749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDN version is the tip of master, which introduced a breaking change for our implementation - moving to local version to avoid that in the future added angular-highlightjs license file
callmehiphop
added
type: bug
googlebot
added
the
cla: yes
Contributor
|
Nice. Good catch. Thanks! |
stephenplusplus
added a commit
that referenced
this pull request
Jul 27, 2015
docs: added local version of angular-highlightjs
Contributor
|
Do you think we should cherry pick this into our gh-pages branch manually so that our docs aren't broken until our Wednesday release? |
Contributor
Author
|
Definitely! |
sofisl
pushed a commit
that referenced
this pull request
Nov 17, 2022
* chore(main): release 3.4.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like angular-hightlightjs recently added UMD support which broke our doc examples since we loaded the directive before the underlying library.
This PR changed the loading order to fix the broken examples and I've also added the directive locally to prevent any future conflicts.