Skip to content

Storage: add https support to getSignedUrl #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mziccard wants to merge 4 commits into from
Closed

Storage: add https support to getSignedUrl #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b40c6f
Add https support to getSignedUrl function
mziccard Apr 9, 2015
9a771a4
Update CONTRIBUTORS
mziccard Apr 9, 2015
b6b8f5a
Fixed missing semicolon
mziccard Apr 9, 2015
f455cce
getSignedUrl always uses https
mziccard Apr 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

Burcu Dogan <[email protected]>
Johan Euphrosine <[email protected]>
Marco Ziccardi <[email protected]>
Patrick Costello <[email protected]>
Silvano Luciani <[email protected]>
Stephen Sawchuk <[email protected]>
2 changes: 1 addition & 1 deletion lib/storage/file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,7 @@ File.prototype.getSignedUrl = function(options, callback) {
var signature = sign.sign(credentials.private_key, 'base64');

callback(null, [
'http://storage.googleapis.com' + options.resource,
'https://storage.googleapis.com' + options.resource,
'?GoogleAccessId=' + credentials.client_email,
'&Expires=' + options.expires,
'&Signature=' + encodeURIComponent(signature)
Expand Down