Fix pagination for queries with offset. #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/datastore/index.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
Done. |
Contributor
|
LGTM. |
rakyll
pushed a commit
that referenced
this pull request
Jul 21, 2014
Fix pagination for queries with offset.
sofisl
pushed a commit
that referenced
this pull request
Sep 15, 2022
This was referenced Sep 15, 2022
sofisl
pushed a commit
that referenced
this pull request
Sep 16, 2022
* chore: lock files maintenance * chore: lock files maintenance
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
* chore: lock files maintenance * chore: lock files maintenance
This was referenced Oct 5, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 8, 2022
* chore: lock files maintenance * chore: lock files maintenance
This was referenced Oct 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
* chore: setup nighty build in CircleCI * chore: setup nighty build in CircleCI
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
This was referenced Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
For each client method returning a long running operation, a separate method to check its status is added. Added methods: `checkApplyParametersProgress`, `checkCreateInstanceProgress`, `checkDeleteInstanceProgress`, `checkUpdateInstanceProgress`, `checkUpdateParametersProgress`.
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/5f7bb900-b4ec-41d2-acea-c5c2f5dfb4fa/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@901ddd4 Source-Link: googleapis/synthtool@f96d3b4
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 392067151 Source-Link: googleapis/googleapis@06345f7 Source-Link: googleapis/googleapis-gen@95882b3
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/nodejs-gke-connect-gateway/compare/v1.0.3...v1.1.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#23](https://www.github.com/googleapis/nodejs-gke-connect-gateway/issues/23)) ([4041bbd](https://www.github.com/googleapis/nodejs-gke-connect-gateway/commit/4041bbd7361a8aecfb86a886d0c7661db52c2e31)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 12, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`^16.0.0` -> `^18.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/16.18.3/18.11.9) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-bare-metal-solution). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDEuMTEiLCJ1cGRhdGVkSW5WZXIiOiIzNC45LjIifQ==-->
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 16, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^9.2.1` -> `^10.0.0`](https://renovatebot.com/diffs/npm/sinon/9.2.4/10.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sinonjs/sinon</summary> ### [`v10.0.0`](https://togithub.com/sinonjs/sinon/blob/master/CHANGELOG.md#​1000--2021-03-22) [Compare Source](https://togithub.com/sinonjs/sinon/compare/v9.2.4...v10.0.0) ================== - Upgrade nise to 4.1.0 - Use [@​sinonjs/eslint-config](https://togithub.com/sinonjs/eslint-config)[@​4](https://togithub.com/4) => Adopts ES2017 => Drops support for IE 11, Legacy Edge and legacy Safari </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-network-connectivity).
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 16, 2022
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 30, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
sofisl
pushed a commit
that referenced
this pull request
Dec 21, 2022
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 468790263 Source-Link: googleapis/googleapis@873ab45 Source-Link: googleapis/googleapis-gen@cb6f37a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
* generated GAPIC v2 code * lint and prettier * WIP: update samples * Upgrade samples + tests * Fix lint errors + add dateshiftconfig sample * Remove extraneous triggers field * Add descriptions to triggers + add missing result file * s/projectId/callingProject/ + remove project id from deleteJob * Add templateId + displayName to templates.js * Remove includeQuote + use dataProjectId * IMPORTANT: properly process multiple buckets * IMPORTANT: properly process multiple buckets, pt 2 * Minor tweaks to deid * Remove inspectconfig-specific print statements * (Almost-)final draft of Node.js DLP samples * Regenerate README * Fix nits * Move require statements to the top of functions * Nit: fix comment * Fix incorrect limit syntax in quickstart * Clarify that filter parameter is not entirely optional * Add missing README sections * Only ack pubsub messages with the desired contents * Update redact images * Missed a spot :( * regenerated v2 GAPIC code, fixed samples and system tests * get rid of unused response variables * unskipping some samples test that actually work * fixing bigquery tests * Finishing touches - add delay to DlpJob retrieval + make DlpJob tests parallel * prettier
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
fix: use google-gax v3.3.0 Source-Link: googleapis/synthtool@c73d112 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
🤖 I have created a release *beep* *boop* --- ## [0.2.3](googleapis/nodejs-run@v0.2.2...v0.2.3) (2022-09-14) ### Bug Fixes * Allow passing gax instance to client constructor ([#24](googleapis/nodejs-run#24)) ([91e2ac5](googleapis/nodejs-run@91e2ac5)) * Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-run/issues/1553)) ([#23](googleapis/nodejs-run#23)) ([acda49f](googleapis/nodejs-run@acda49f)) * Preserve default values in x-goog-request-params header ([#26](googleapis/nodejs-run#26)) ([debc1eb](googleapis/nodejs-run@debc1eb)) * use google-gax v3.3.0 ([acda49f](googleapis/nodejs-run@acda49f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Jan 10, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 26, 2023
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/cb56ba31-8af5-4a2d-bb02-4d94fe4706d8/targets - [ ] To automatically regenerate this PR, check this box. PiperOrigin-RevId: 345596855 Source-Link: googleapis/googleapis@d189e87
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Feb 23, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`^16.0.0` -> `^18.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/16.18.3/18.11.9) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-dataform). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDEuMTEiLCJ1cGRhdGVkSW5WZXIiOiIzNC4xMS4xIn0=-->
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 13, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | [`^16.0.0` -> `^18.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/16.18.3/18.11.9) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-apigee-registry). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDEuMTEiLCJ1cGRhdGVkSW5WZXIiOiIzNC4xMS4xIn0=-->
This was referenced Sep 13, 2023
sofisl
pushed a commit
that referenced
this pull request
Sep 13, 2023
4 tasks
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
* Refactor createApiCall Currently createApiCall assumes to receive a function and a CallSettings instance, and then returns a function. On the reality, however, the API function can't be a normal function but a Promise to a function (due to the asynchronous-ness of auth library) and therefore, it's hard to handle the return value of the code upon usage. With this refactoring, the generated code can simply invokes createApiCall with a Promise stub, and it simplifies the return values. This is a preparation to #20, which requires a different type of return value to non-page-streaming functions, and #22 which will also return a value. This also reduces the size of the generated code because the pattern used in the API call can be simplified. See jmuk/toolkit@ec23b25 to see how it's simplified. * Style fix * rename func by funcWithAuth * Fix a typo
miguelvelezsa
pushed a commit
that referenced
this pull request
Sep 17, 2025
](https://renovatebot.com){kind=link}
Run `npm upgrade` to bring dependencies up to date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the offset only to the first page, to avoid losing results in the following pages.