Skip to content

Vision: Add 'gccl' header. #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephenplusplus merged 2 commits into from
Apr 17, 2017
Merged

Vision: Add 'gccl' header. #2228

stephenplusplus merged 2 commits into from
Apr 17, 2017

Conversation

@landrito
Copy link
Contributor

@landrito landrito commented Apr 17, 2017 •
edited
Loading

Updates #2225

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2017
@stephenplusplus stephenplusplus added the api: vision Issues related to the Cloud Vision API. label Apr 17, 2017
stephenplusplus
stephenplusplus suggested changes Apr 17, 2017
View reviewed changes
Copy link
Contributor

@stephenplusplus stephenplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - would you mind adding a test? Here's the one from Language: https://github.com/GoogleCloudPlatform/google-cloud-node/blob/03e6373a8edf137b22f01d24f7602964cf530d8f/packages/language/test/index.js#L115

@landrito landrito mentioned this pull request Apr 17, 2017
Closed
@landrito
Copy link
Contributor Author

landrito commented Apr 17, 2017

Will do!

@stephenplusplus
Copy link
Contributor

stephenplusplus commented Apr 17, 2017

One of the tests wasn't happy:


  1) Vision instantiation should create a gax api client:

      AssertionError: { projectId: 'project-id',
  libName: 'gccl',
  libVersion: '0.11.1' } === { projectId: 'project-id' }
      + expected - actual

       {
      -  "libName": "gccl"
      -  "libVersion": "0.11.1"
         "projectId": "project-id"
       }
      
      at Object.imageAnnotatorClient (test/index.js:117:20)
      at new Vision (src/index.js:69:25)
      at Context.<anonymous> (test/index.js:123:20)

https://circleci.com/gh/GoogleCloudPlatform/google-cloud-node/812?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@landrito
Copy link
Contributor Author

landrito commented Apr 17, 2017

Fixed.

@stephenplusplus stephenplusplus merged commit c0a3e41 into googleapis:master Apr 17, 2017
@coveralls
Copy link

coveralls commented Apr 17, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 70970b9 on landrito:vision into 1d1f491 on GoogleCloudPlatform:master.

@sofisl sofisl mentioned this pull request Jan 17, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Jan 17, 2023
@landrito @stephenplusplus
Vision: Add 'gccl' header. (#2228)
4a66332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

1 more reviewer

@stephenplusplus stephenplusplus stephenplusplus requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@landrito @stephenplusplus @coveralls @googlebot