updated FQDN's to googleapis.com with a trailing dot

[ericuldall]

** edit by @stephenplusplus **

Due to an issue brought up in #2249, we have reverted this change.

---

PR for Issue #2213

[coveralls]

Coverage remained the same at 100.0% when pulling c786850 on restorationmedia:issue-2213-fqdn-trailing-dot into 184f9bb on GoogleCloudPlatform:master.

[ericuldall]

I caught an issue where scopes cannot have the trailing dot. I'm fixing that now.

[ericuldall]

I think I got them all, per grep -rni 'googleapis\.com\./auth' * from root of repo

[coveralls]

Coverage remained the same at 100.0% when pulling a2115be on restorationmedia:issue-2213-fqdn-trailing-dot into 184f9bb on GoogleCloudPlatform:master.

[coveralls]

Coverage remained the same at 100.0% when pulling cada67e on restorationmedia:issue-2213-fqdn-trailing-dot into 184f9bb on GoogleCloudPlatform:master.

[lukesneeringer]

I am saying no to this PR. I recognize that there are locations where a trailing period is appropriate (e.g. a BIND configuration file), but its general use in URLs is not one of those places.

And, in fact, when I actually try to use a URL with a trailing dot, I get redirected to the URL without it:

$ curl -I https://github.com./GoogleCloudPlatform
HTTP/1.1 301 Moved Permanently
Content-length: 0
Location: https://github.com/GoogleCloudPlatform
Connection: close

Additionally, this violates the principle of lease surprise. Even if it were a tiny benefit to write the URLs this way, the level of "huh?" caused by people who read it would be...high.

[lukesneeringer]

I discussed this with our team internally and have been persuaded. I do want you to change the maximum line length back to 80, though.

[ericuldall]

Sure, I can certainly move that back to 80 chars. What is the suggested style choice for the baseUrl lines that have reached 81 chars in the line?

[ericuldall]

Will something like this be acceptable?

  ¦ it('should set the default base URL', function() {
  ¦ ¦ assert.strictEqual(
  ¦ ¦ ¦ datastore.defaultBaseUrl_,
  ¦ ¦ ¦ 'datastore.googleapis.com.'
  ¦ ¦ );
  ¦ });

[stephenplusplus]

Regarding style, whatever you think works best for the block the code is in, including renaming vars to be shorter, or:

var url = [
  'http://www.googleapis.com./...',
  'other-part'
].join('/');

Anything you come up I'm sure will be just fine, and thanks very much for asking!

Will something like this be acceptable:

Yep, that's perfect 👍

[ericuldall]

Okay, changes made and rebased from upstream. Let me know if anything else needs to change.

[coveralls]

Changes Unknown when pulling c343a6e on restorationmedia:issue-2213-fqdn-trailing-dot into ** on GoogleCloudPlatform:master**.

[stephenplusplus]

Just assigning to myself -- running the system tests locally had a couple failures, so I'll need to comb over and make sure we've got the dots in the right spots.

[lukesneeringer]

@stephenplusplus No need to do an entire umbrella release for this, but maybe release BigTable for @ericuldall. The rest of them can just show up when we release for other reasons.

[stephenplusplus]

I stacked on a commit which removes the changes from areas that weren't working as expected and in the files that are generated-- those will have to be edited upstream.

@landrito @jmuk in the generated files, would you be interested in taking on this change?

[coveralls]

Coverage remained the same at 100.0% when pulling 773625b on restorationmedia:issue-2213-fqdn-trailing-dot into fa3e960 on GoogleCloudPlatform:master.

[stephenplusplus]

Due to an issue brought up in #2249, we have reverted this change.