Skip to content

logging-winston: avoid printing to console during test #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenplusplus merged 2 commits into from
Feb 13, 2017
Merged

logging-winston: avoid printing to console during test #1985

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45d234b
avoid printing to console during test
ofrobots Feb 11, 2017
d4ce9fc
style
stephenplusplus Feb 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/logging-winston/system-test/logging-winston.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,16 @@ var winston = require('winston');
var env = require('../../../system-test/env.js');

var logging = require('@google-cloud/logging')(env);
var loggingWinston = require('../');
var LoggingWinston = require('../');

describe('LoggingWinston', function() {
var WRITE_CONSISTENCY_DELAY_MS = 20000;

winston.add(loggingWinston, env);
var logger = new winston.Logger({
transports: [
new LoggingWinston(env)
]
});

describe('log', function() {
var testTimestamp = new Date();
Expand Down Expand Up @@ -69,7 +73,7 @@ describe('LoggingWinston', function() {

it('should properly write log entries', function(done) {
async.each(testData, function(test, callback) {
winston.info.apply(winston, test.args.concat(callback));
logger.info.apply(logger, test.args.concat(callback));
}, function(err) {
assert.ifError(err);

Expand Down