Skip to content

Bigtable prefix #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephenplusplus merged 3 commits into from
Nov 17, 2016
Merged

Bigtable prefix #1802

stephenplusplus merged 3 commits into from
Nov 17, 2016

Conversation

@callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Nov 17, 2016

Closes #1790

@callmehiphop callmehiphop added the api: bigtable Issues related to the Bigtable API. label Nov 17, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2016
@callmehiphop
Copy link
Contributor Author

callmehiphop commented Nov 17, 2016 •
edited
Loading

/cc @jgeewax @mbrukman

@coveralls
Copy link

coveralls commented Nov 17, 2016

Coverage Status

Changes Unknown when pulling 637486a on callmehiphop:bigtable-prefix into * on GoogleCloudPlatform:master*.

@stephenplusplus
Copy link
Contributor

stephenplusplus commented Nov 17, 2016

Code looks good to me. I pinged our friend @sindresorhus to hopefully check out the createPrefixRange_ function. If I recall correctly, character codes and string lengths in JS have been areas of trickery, so I just want to make sure that's gotcha-proof.

@stephenplusplus stephenplusplus merged commit 8047652 into googleapis:master Nov 17, 2016
@takeratta takeratta mentioned this pull request Jul 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@stephenplusplus stephenplusplus

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@callmehiphop @coveralls @stephenplusplus @googlebot