Skip to content

Conversation

@stephenplusplus
Copy link
Contributor

No description provided.

@stephenplusplus stephenplusplus added the api: monitoring Issues related to the Cloud Monitoring API. label Oct 21, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2016
@stephenplusplus stephenplusplus added the status: blocked Resolving the issue is dependent on other work. label Oct 21, 2016
@stephenplusplus
Copy link
Contributor Author

@landrito @jmuk we're getting an error trying to use the generated API:

https://github.com/GoogleCloudPlatform/google-cloud-node/blob/97207ec97bea51bfc9049c6a818a6ee7338bdadf/packages/monitoring/src/v3/group_service_api.js#L524

var groupServiceClient = require('grpc-google-monitoring-v3').client;

grpc-google-monitoring-v3 doesn't exist on npm and isn't a dependency. Is this a typo?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7d6d122 on stephenplusplus:spp--monitoring-hello into 4a4493a on GoogleCloudPlatform:master.

@landrito
Copy link
Contributor

I suspect that I generated the file with an incorrect package name which caused this error because the gapic-yaml package name is not here. I'll regenerate. Sec

@landrito
Copy link
Contributor

landrito commented Oct 21, 2016

I regenerated at #1741.

@stephenplusplus stephenplusplus removed the status: blocked Resolving the issue is dependent on other work. label Oct 22, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 58e7806 on stephenplusplus:spp--monitoring-hello into f8f713a on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 28247c6 into googleapis:master Oct 24, 2016
miguelvelezsa pushed a commit that referenced this pull request Jul 23, 2025
* Add errorsEncountered to the errors sent back

* Add code to append to details information about

previous errors

* Remove the errorsEncountered property

* Add a test for including retried errors in the

error details

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Add something to make the test fail

* Add an assert fail statement

* Use the statusDetails property

The details property is not the right property

* stringify the error so that we can investigate its

value

* Add a line of code that will help us see where the

data is stringified

* Log the message for the error

* Try modifying the test to use captureStderr

* Rename testUtils

* Add header

* Try printing the message for the test

* Add the expected message

* Remove test utils

* Add another test for a basic client

* Try this - it probably forms a unary call

* Make a test that looks for the previous errors str

* Add a console log to the debugging

* Add another log

* Remove test that we don’t use

* Remove the console logs

* remove console logs

* Add the message and make output prettier

* Add a test for testing the echo error

* Add the expected error message

* Remove the streaming test

* no sinon change

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: monitoring Issues related to the Cloud Monitoring API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants